You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Ralf Hauser (JIRA)" <ji...@apache.org> on 2008/04/22 10:05:05 UTC

[jira] Created: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

do not set form-file silently to null if setXXX() method is not specific enough
-------------------------------------------------------------------------------

                 Key: STR-3142
                 URL: https://issues.apache.org/struts/browse/STR-3142
             Project: Struts 1
          Issue Type: Bug
    Affects Versions: 1.3.9
         Environment: any
            Reporter: Ralf Hauser


as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to

public void setFile(Object file) {
   this file= (FormFile) file;
}

it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/STR-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44068#action_44068 ] 

Ralf Hauser commented on STR-3142:
----------------------------------

if there is a setter method with the correct name, but the method argument is more generic than excepted (class Object instead of FormFile), the setter is considered inexistent instead of a warning being raised

> do not set form-file silently to null if setXXX() method is not specific enough
> -------------------------------------------------------------------------------
>
>                 Key: STR-3142
>                 URL: https://issues.apache.org/struts/browse/STR-3142
>             Project: Struts 1
>          Issue Type: Bug
>    Affects Versions: 1.3.9
>         Environment: any
>            Reporter: Ralf Hauser
>             Fix For: Pending Review
>
>
> as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to
> public void setFile(Object file) {
>    this file= (FormFile) file;
> }
> it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/STR-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45365#action_45365 ] 

Ralf Hauser commented on STR-3142:
----------------------------------

let's hope the fix to https://issues.apache.org/jira/browse/BEANUTILS-224 give the additional error/debug hints sought

> do not set form-file silently to null if setXXX() method is not specific enough
> -------------------------------------------------------------------------------
>
>                 Key: STR-3142
>                 URL: https://issues.apache.org/struts/browse/STR-3142
>             Project: Struts 1
>          Issue Type: Bug
>    Affects Versions: 1.3.9
>         Environment: any
>            Reporter: Ralf Hauser
>            Assignee: Paul Benedict
>
> as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to
> public void setFile(Object file) {
>    this file= (FormFile) file;
> }
> it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/STR-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44065#action_44065 ] 

Paul Benedict commented on STR-3142:
------------------------------------

Can you provide more info please? What defect is being reported?

> do not set form-file silently to null if setXXX() method is not specific enough
> -------------------------------------------------------------------------------
>
>                 Key: STR-3142
>                 URL: https://issues.apache.org/struts/browse/STR-3142
>             Project: Struts 1
>          Issue Type: Bug
>    Affects Versions: 1.3.9
>         Environment: any
>            Reporter: Ralf Hauser
>             Fix For: Pending Review
>
>
> as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to
> public void setFile(Object file) {
>    this file= (FormFile) file;
> }
> it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict updated STR-3142:
-------------------------------

    Fix Version/s: Pending Review

> do not set form-file silently to null if setXXX() method is not specific enough
> -------------------------------------------------------------------------------
>
>                 Key: STR-3142
>                 URL: https://issues.apache.org/struts/browse/STR-3142
>             Project: Struts 1
>          Issue Type: Bug
>    Affects Versions: 1.3.9
>         Environment: any
>            Reporter: Ralf Hauser
>             Fix For: Pending Review
>
>
> as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to
> public void setFile(Object file) {
>    this file= (FormFile) file;
> }
> it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (STR-3142) do not set form-file silently to null if setXXX() method is not specific enough

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict closed STR-3142.
------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: Pending Review)
         Assignee: Paul Benedict

Form population is delegated to Apache Commons BeanUtils, and it finds method according to the JavaBean spec. The issue you raised actually deals a violation to the JavaBean spec.

> do not set form-file silently to null if setXXX() method is not specific enough
> -------------------------------------------------------------------------------
>
>                 Key: STR-3142
>                 URL: https://issues.apache.org/struts/browse/STR-3142
>             Project: Struts 1
>          Issue Type: Bug
>    Affects Versions: 1.3.9
>         Environment: any
>            Reporter: Ralf Hauser
>            Assignee: Paul Benedict
>
> as a (unsuccessful) workaround for STR-2778, I changed the set method in a ActionForm object to
> public void setFile(Object file) {
>    this file= (FormFile) file;
> }
> it seems that struts does not like this setter and silently ignores it  :(

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.