[GitHub] [druid] gianm commented on a change in pull request #9251: fix issue with long column predicate matcher based filters and nulls

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9251: fix issue with long column predicate matcher based filters and nulls
URL: https://github.com/apache/druid/pull/9251#discussion_r370892848
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
 ##########
 @@ -3198,6 +3198,69 @@ public void testNullLongTopN() throws Exception
     );
   }
 
+  @Test
+  public void testLongPredicateFilterNulls() throws Exception
+  {
+    testQuery(
+        "SELECT COUNT(*)\n"
+        + "FROM druid.numfoo\n"
+        + "WHERE l1 > 3",
+        ImmutableList.of(
+            Druids.newTimeseriesQueryBuilder()
+                  .dataSource(CalciteTests.DATASOURCE3)
+                  .intervals(querySegmentSpec(Filtration.eternity()))
+                  .granularity(Granularities.ALL)
+                  .filters(bound("l1", "3", null, true, false, null, StringComparators.NUMERIC))
 
 Review comment:
   How about moving these three tests to `BoundFilterTest`? I suggest this for two reasons:
   
   1) This test isn't adding much to coverage of the SQL layer.
   2) BoundFilterTest extends from BaseFilterTest which tests a whole big matrix of configurations, so coverage of the lower level stuff will be better vs. using CalciteQueryTest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org