[jira] [Commented] (HADOOP-9784) Add builder in creating HttpServer

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723697#comment-13723697 ] 

Hadoop QA commented on HADOOP-9784:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594890/HADOOP-9784.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 1162 javac compiler warnings (more than the trunk's current 1152 warnings).

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.http.TestHttpServerLifecycle
                  org.apache.hadoop.log.TestLogLevel
                  org.apache.hadoop.http.TestHttpServerWebapps
                  org.apache.hadoop.jmx.TestJMXJsonServlet
                  org.apache.hadoop.http.TestHttpServer
                  org.apache.hadoop.hdfs.server.namenode.TestEditLogFileInputStream
                  org.apache.hadoop.hdfs.server.namenode.TestTransferFsImage

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2883//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2883//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2883//console

This message is automatically generated.
                
> Add builder in creating HttpServer
> ----------------------------------
>
>                 Key: HADOOP-9784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9784
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HADOOP-9784.patch
>
>
> There are quite a lot of constructors in class of HttpServer to create instance. Create a builder class to abstract the building steps which helps to avoid more constructors in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira