You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/03 14:05:45 UTC
[GitHub] [apisix-ingress-controller] nic-6443 opened a new pull request #829: fix: objects get from lister must be treated as read-only
nic-6443 opened a new pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
The object returned by the kubernetes listserver interface should be immutable, and this rule is explicitly stated in the listserver interface.
```
// IngressNamespaceLister helps list and get Ingresses.
// All objects returned here must be treated as read-only.
type IngressNamespaceLister interface {
}
```
If change the object, it will cause some strange behavior, for example: the `oldObject` you get in the `control.onUpdate` callback is incorrect.
```
2021-12-31T13:33:58+08:00 debug ingress/ingress.go:267 ingress add event arrived {"object": "&Ingress{ObjectMeta:{ingress-v1-lb ingress-apisix-e2e-tests-default-513114146 394be781-cba8-4b3e-8249-87f7a96c4997 15867 1 2021-12-31 13:33:58 +0800 HKT <nil> <nil> map[] map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"networking.k8s.io/v1\",\"kind\":\"Ingress\",\"metadata\":{\"annotations\":{\"kubernetes.io/ingress.class\":\"apisix\"},\"name\":\"ingress-v1-lb\",\"namespace\":\"ingress-apisix-e2e-tests-default-513114146\"},\"spec\":{\"rules\":[{\"host\":\"httpbin.org\",\"http\":{\"paths\":[{\"backend\":{\"service\":{\"name\":\"httpbin-service-e2e-test\",\"port\":{\"number\":80}}},\"path\":\"/ip\",\"pathType\":\"Exact\"}]}}]}}\n kubernetes.io/ingress.class:apisix] [] [] [{kubectl-client-side-apply Update networking.k8s.io/v1 2021-12-31 13:33:58 +0800 HKT FieldsV1 {\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuration\":{},
\"f:kubernetes.io/ingress.class\":{}}},\"f:spec\":{\"f:rules\":{}}} }]},Spec:IngressSpec{DefaultBackend:nil,TLS:[]IngressTLS{},Rules:[]IngressRule{IngressRule{Host:httpbin.org,IngressRuleValue:IngressRuleValue{HTTP:&HTTPIngressRuleValue{Paths:[]HTTPIngressPath{HTTPIngressPath{Path:/ip,Backend:IngressBackend{Resource:nil,Service:&IngressServiceBackend{Name:httpbin-service-e2e-test,Port:ServiceBackendPort{Name:,Number:80,},},},PathType:*Exact,},},},},},},IngressClassName:nil,},Status:IngressStatus{LoadBalancer:{[]},},}"}
2021-12-31T13:33:59+08:00 debug ingress/ingress.go:302 ingress update event arrived {"new object": "&Ingress{ObjectMeta:{ingress-v1-lb ingress-apisix-e2e-tests-default-513114146 394be781-cba8-4b3e-8249-87f7a96c4997 15868 1 2021-12-31 13:33:58 +0800 HKT <nil> <nil> map[] map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"networking.k8s.io/v1\",\"kind\":\"Ingress\",\"metadata\":{\"annotations\":{\"kubernetes.io/ingress.class\":\"apisix\"},\"name\":\"ingress-v1-lb\",\"namespace\":\"ingress-apisix-e2e-tests-default-513114146\"},\"spec\":{\"rules\":[{\"host\":\"httpbin.org\",\"http\":{\"paths\":[{\"backend\":{\"service\":{\"name\":\"httpbin-service-e2e-test\",\"port\":{\"number\":80}}},\"path\":\"/ip\",\"pathType\":\"Exact\"}]}}]}}\n kubernetes.io/ingress.class:apisix] [] [] [{kubectl-client-side-apply Update networking.k8s.io/v1 2021-12-31 13:33:58 +0800 HKT FieldsV1 {\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuratio
n\":{},\"f:kubernetes.io/ingress.class\":{}}},\"f:spec\":{\"f:rules\":{}}} } {apisix-ingress-controller Update networking.k8s.io/v1 2021-12-31 13:33:59 +0800 HKT FieldsV1 {\"f:status\":{\"f:loadBalancer\":{\"f:ingress\":{}}}} }]},Spec:IngressSpec{DefaultBackend:nil,TLS:[]IngressTLS{},Rules:[]IngressRule{IngressRule{Host:httpbin.org,IngressRuleValue:IngressRuleValue{HTTP:&HTTPIngressRuleValue{Paths:[]HTTPIngressPath{HTTPIngressPath{Path:/ip,Backend:IngressBackend{Resource:nil,Service:&IngressServiceBackend{Name:httpbin-service-e2e-test,Port:ServiceBackendPort{Name:,Number:80,},},},PathType:*Exact,},},},},},},IngressClassName:nil,},Status:IngressStatus{LoadBalancer:{[{10.6.6.6 []}]},},}", "old object": "&Ingress{ObjectMeta:{ingress-v1-lb ingress-apisix-e2e-tests-default-513114146 394be781-cba8-4b3e-8249-87f7a96c4997 15867 1 2021-12-31 13:33:58 +0800 HKT <nil> <nil> map[] map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"networking.k8s.io/v1\",\"kind\":\"Ingress
\",\"metadata\":{\"annotations\":{\"kubernetes.io/ingress.class\":\"apisix\"},\"name\":\"ingress-v1-lb\",\"namespace\":\"ingress-apisix-e2e-tests-default-513114146\"},\"spec\":{\"rules\":[{\"host\":\"httpbin.org\",\"http\":{\"paths\":[{\"backend\":{\"service\":{\"name\":\"httpbin-service-e2e-test\",\"port\":{\"number\":80}}},\"path\":\"/ip\",\"pathType\":\"Exact\"}]}}]}}\n kubernetes.io/ingress.class:apisix] [] [] [{kubectl-client-side-apply Update networking.k8s.io/v1 2021-12-31 13:33:58 +0800 HKT FieldsV1 {\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuration\":{},\"f:kubernetes.io/ingress.class\":{}}},\"f:spec\":{\"f:rules\":{}}} }]},Spec:IngressSpec{DefaultBackend:nil,TLS:[]IngressTLS{},Rules:[]IngressRule{IngressRule{Host:httpbin.org,IngressRuleValue:IngressRuleValue{HTTP:&HTTPIngressRuleValue{Paths:[]HTTPIngressPath{HTTPIngressPath{Path:/ip,Backend:IngressBackend{Resource:nil,Service:&IngressServiceBackend{Name:httpbin-service-e2e-te
st,Port:ServiceBackendPort{Name:,Number:80,},},},PathType:*Exact,},},},},},},IngressClassName:nil,},Status:IngressStatus{LoadBalancer:{[{10.6.6.6 []}]},},}"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1041278535
Can you merge from master branch? we have fixed the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1033319304
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#829](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ccd07d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b0c139ce2fbf56c683d86b8f93c7b4ef854fbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b0c139) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 32.07% 32.07%
=======================================
Files 70 71 +1
Lines 7736 7739 +3
=======================================
+ Hits 2481 2482 +1
- Misses 4980 4982 +2
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b0c139...1ccd07d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1033319304
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#829](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ccd07d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b0c139ce2fbf56c683d86b8f93c7b4ef854fbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b0c139) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 32.07% 32.06% -0.01%
==========================================
Files 70 70
Lines 7736 7738 +2
==========================================
Hits 2481 2481
- Misses 4980 4982 +2
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b0c139...1ccd07d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1041278535
can you merge from master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] nic-6443 commented on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
nic-6443 commented on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1041301820
> Can you merge from master branch? we have fixed the CI
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #829: fix: objects get from lister must be treated as read-only
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #829:
URL: https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1033319304
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#829](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83cf5d3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/df8316aaceec40ae86857b1ef972a812c55b1252?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8316a) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 32.12% 32.11% -0.02%
==========================================
Files 71 70 -1
Lines 7725 7726 +1
==========================================
- Hits 2482 2481 -1
- Misses 4968 4970 +2
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df8316a...83cf5d3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org