You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/11 17:54:41 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8085: Add common virtual region allocator

xiaoxiang781216 commented on code in PR #8085:
URL: https://github.com/apache/nuttx/pull/8085#discussion_r1067293203


##########
mm/shm/shmat.c:
##########
@@ -80,7 +80,8 @@ static int munmap_shm(FAR struct task_group_s *group,
     {
       /* Free the virtual address space */
 
-      shm_free(group, (FAR void *)shmaddr, region->sr_ds.shm_segsz);
+      vm_release_region(get_group_mm(group), (FAR void *)shmaddr,

Review Comment:
   remove the const from line 50 and the cast here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org