You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by nikpawar89 <gi...@git.apache.org> on 2016/08/04 11:27:54 UTC
[GitHub] incubator-fineract pull request #195: address_module
GitHub user nikpawar89 opened a pull request:
https://github.com/apache/incubator-fineract/pull/195
address_module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikpawar89/incubator-fineract addressbackend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit 3f9d4325e55e563f2788d939b45f1be8987fa1c1
Author: nikpawar89 <ni...@yahoo.in>
Date: 2016-07-19T06:08:06Z
address_module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73839229
--- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java ---
@@ -41,10 +41,37 @@
private String transactionId;
private Long productId;
private Long templateId;
+
public CommandWrapper build() {
return new CommandWrapper(this.officeId, this.groupId, this.clientId, this.loanId, this.savingsId, this.actionName,
- this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId, this.templateId);
+ this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId,
+ this.templateId);
+ }
+
+ public CommandWrapperBuilder addClientAddress(final long clientId,final long addressTypeId) {
+ this.actionName = "CREATE";
+ this.entityName = "ADDRESS";
+ this.entityId = addressTypeId;
+ this.href = "/Address/template";
+ this.clientId=clientId;
+ return this;
+ }
+
+ public CommandWrapperBuilder updateClientAddress(final long clientId) {
+ this.actionName = "UPDATE";
+ this.entityName = "ADDRESS";
+ this.href = "/Address/template";
+ this.clientId=clientId;
+ return this;
+ }
+
+ public CommandWrapperBuilder addEntityFieldConfiguration(final String entityname) {
+ this.actionName = "MAP";
+ this.entityName = entityname.toUpperCase();
+ this.entityId = null;
+ this.href = "/Address/template";
--- End diff --
Still it doesn't show correct url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73839210
--- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java ---
@@ -41,10 +41,37 @@
private String transactionId;
private Long productId;
private Long templateId;
+
public CommandWrapper build() {
return new CommandWrapper(this.officeId, this.groupId, this.clientId, this.loanId, this.savingsId, this.actionName,
- this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId, this.templateId);
+ this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId,
+ this.templateId);
+ }
+
+ public CommandWrapperBuilder addClientAddress(final long clientId,final long addressTypeId) {
+ this.actionName = "CREATE";
+ this.entityName = "ADDRESS";
+ this.entityId = addressTypeId;
+ this.href = "/Address/template";
+ this.clientId=clientId;
+ return this;
+ }
+
+ public CommandWrapperBuilder updateClientAddress(final long clientId) {
+ this.actionName = "UPDATE";
+ this.entityName = "ADDRESS";
+ this.href = "/Address/template";
--- End diff --
Still it doesn't show correct url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996805
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
--- End diff --
would change it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73839085
--- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandWrapper.java ---
@@ -38,6 +38,8 @@
private final String json;
--- End diff --
This file should not be part of pull request as it is having only formatting issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73999278
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java ---
@@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext context,
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false") @QueryParam("survey") final boolean survey) {
+ public String retrieveConfiguration(@Context final UriInfo uriInfo,
--- End diff --
I don't know whether you have followed our discussion. Let me put it here what I understood. You are supposed to add a new method in read platform service. Not in the API resource. Let me know if you differ this :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73839195
--- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java ---
@@ -41,10 +41,37 @@
private String transactionId;
private Long productId;
private Long templateId;
+
public CommandWrapper build() {
return new CommandWrapper(this.officeId, this.groupId, this.clientId, this.loanId, this.savingsId, this.actionName,
- this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId, this.templateId);
+ this.entityName, this.entityId, this.subentityId, this.href, this.json, this.transactionId, this.productId,
+ this.templateId);
+ }
+
+ public CommandWrapperBuilder addClientAddress(final long clientId,final long addressTypeId) {
+ this.actionName = "CREATE";
+ this.entityName = "ADDRESS";
+ this.entityId = addressTypeId;
+ this.href = "/Address/template";
--- End diff --
href doesn't show correct url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996719
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (151, 'COUNTRY ID', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (152, 'ADDRESS TYPE ID', 0);
+
+--add new column in portfolio
+alter table `m_portfolio_command_source` add column `status` TINYINT(4) NULL DEFAULT NULL;
+
+--configuration
+INSERT INTO `c_configuration` (`id`, `name`, `value`, `date_value`, `enabled`, `is_trap_door`, `description`) VALUES ('Enable-Address', NULL, NULL, 1, 0, NULL);
--- End diff --
This insert statement will fail as parameters and actual values length is not matching
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r74000777
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java ---
@@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext context,
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false") @QueryParam("survey") final boolean survey) {
+ public String retrieveConfiguration(@Context final UriInfo uriInfo,
--- End diff --
Ok let me explain you, why I needed to add additional parameter, configname in APi.
In Community App, we have added a functionality wherein, only if address configuration is enabled, the address of the clients would be displayed.
In order to make this functionality work independent of id, I had to modify the api, to get the configuration by name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996829
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (151, 'COUNTRY ID', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (152, 'ADDRESS TYPE ID', 0);
+
+--add new column in portfolio
+alter table `m_portfolio_command_source` add column `status` TINYINT(4) NULL DEFAULT NULL;
+
+--configuration
+INSERT INTO `c_configuration` (`id`, `name`, `value`, `date_value`, `enabled`, `is_trap_door`, `description`) VALUES ('Enable-Address', NULL, NULL, 1, 0, NULL);
--- End diff --
would alter it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996854
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (151, 'COUNTRY ID', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (152, 'ADDRESS TYPE ID', 0);
+
+--add new column in portfolio
+alter table `m_portfolio_command_source` add column `status` TINYINT(4) NULL DEFAULT NULL;
--- End diff --
ok.. would not alter the table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73839002
--- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java ---
@@ -129,8 +130,11 @@ public void markAsRejected(final AppUser checker, final DateTime checkedOnDate){
this.checkedOnDate = checkedOnDate.toDate();
this.processingResult = CommandProcessingResultType.REJECTED.getValue();
}
+
+
+
- public void updateResourceId(final Long resourceId) {
+ public void updateResourceId(final Long resourceId) {
--- End diff --
This file should not be part of pull request as it is having only formatting issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996569
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (151, 'COUNTRY ID', 0);
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (152, 'ADDRESS TYPE ID', 0);
+
+--add new column in portfolio
+alter table `m_portfolio_command_source` add column `status` TINYINT(4) NULL DEFAULT NULL;
--- End diff --
with current approach you no need to alter m_portfolio_command_source table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996647
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
@@ -0,0 +1,124 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+--code inserts
+INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
--- End diff --
You should not insert id as they are auto incremented and the insert will fail if m_code table already has these ids
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73998908
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java ---
@@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext context,
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false") @QueryParam("survey") final boolean survey) {
+ public String retrieveConfiguration(@Context final UriInfo uriInfo,
--- End diff --
Hi Nazeer,
This is the new configuration:
public String retrieveConfiguration(@Context final UriInfo uriInfo,@QueryParam("configName") final String configName,@DefaultValue("false") @QueryParam("survey") final boolean survey)
I have added configName as new parameter, beacuse we are going to fetch configuration by the name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 closed the pull request at:
https://github.com/apache/incubator-fineract/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73996988
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java ---
@@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext context,
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false") @QueryParam("survey") final boolean survey) {
+ public String retrieveConfiguration(@Context final UriInfo uriInfo,
--- End diff --
Why do you need to change GlobalConfigurationApiResource API definitions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #195: address_module
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/195#discussion_r73999353
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java ---
@@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext context,
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false") @QueryParam("survey") final boolean survey) {
+ public String retrieveConfiguration(@Context final UriInfo uriInfo,
--- End diff --
got your point.. i will undo changes in API.. sorry for the confusion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---