You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/10 05:22:49 UTC
[GitHub] [incubator-inlong] yunqingmoswu opened a new pull request #3038: [INLONG-3037] Add field mapping support for source and sink in manage client
yunqingmoswu opened a new pull request #3038:
URL: https://github.com/apache/incubator-inlong/pull/3038
### Title Name: [INLONG-3037] Add field mapping support for source and sink in manage client
Fixes #3037
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3038: [INLONG-3037][Manager] Add field mapping support for source and sink in manage client
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on a change in pull request #3038:
URL: https://github.com/apache/incubator-inlong/pull/3038#discussion_r823371671
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/ClickHouseSink.java
##########
@@ -79,7 +78,7 @@
private boolean needCreated;
@ApiModelProperty("Field definitions for kafka")
Review comment:
done
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/KafkaSink.java
##########
@@ -19,18 +19,17 @@
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
+import java.util.List;
+import java.util.Map;
import lombok.AllArgsConstructor;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor;
import org.apache.inlong.manager.client.api.DataFormat;
-import org.apache.inlong.manager.client.api.StreamField;
+import org.apache.inlong.manager.client.api.SinkField;
import org.apache.inlong.manager.client.api.StreamSink;
import org.apache.inlong.manager.common.enums.SinkType;
-import java.util.List;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #3038: [INLONG-3037][Manager] Add field mapping support for source and sink in manage client
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3038:
URL: https://github.com/apache/incubator-inlong/pull/3038#discussion_r823360869
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/ClickHouseSink.java
##########
@@ -79,7 +78,7 @@
private boolean needCreated;
@ApiModelProperty("Field definitions for kafka")
Review comment:
This is ClickHouse sink, not kafka.
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/KafkaSink.java
##########
@@ -19,18 +19,17 @@
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
+import java.util.List;
+import java.util.Map;
import lombok.AllArgsConstructor;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor;
import org.apache.inlong.manager.client.api.DataFormat;
-import org.apache.inlong.manager.client.api.StreamField;
+import org.apache.inlong.manager.client.api.SinkField;
import org.apache.inlong.manager.client.api.StreamSink;
import org.apache.inlong.manager.common.enums.SinkType;
-import java.util.List;
Review comment:
The import config maybe not be correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3038: [INLONG-3037][Manager] Add field mapping support for source and sink in manage client
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3038:
URL: https://github.com/apache/incubator-inlong/pull/3038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org