You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "Daniel Qian (Jira)" <ji...@apache.org> on 2019/11/14 07:19:00 UTC

[jira] [Comment Edited] (SCB-1573) Cleanup third party dep version

    [ https://issues.apache.org/jira/browse/SCB-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973974#comment-16973974 ] 

Daniel Qian edited comment on SCB-1573 at 11/14/19 7:18 AM:
------------------------------------------------------------

The dependency tree is complex, you can got two different version of 3rd-party through two different dependency paths.

I tried my best to unify the third party dependency versions, and below are the remaining inconsistent dependencies version:

{{

com.atlassian.commonmark:commonmark:jar:0.11.0:compile 
 by by org.openapitools:openapi-generator:jar:4.1.2:compile
com.atlassian.commonmark:commonmark:jar:0.9.0:compile
 by by io.swagger:swagger-codegen:jar:2.4.3

com.google.code.findbugs:jsr305:jar:3.0.1:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
 by org.apache.maven:maven-core:jar:3.6.0:compile

com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
 by org.apache.maven:maven-core:jar:3.6.0:compile
com.google.errorprone:error_prone_annotations:jar:2.2.0:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile

com.google.guava:guava:jar:18.0:compile
 by io.airlift:airline:jar:0.7:compile
com.google.guava:guava:jar:25.1-android:compile
 by org.apache.maven:maven-core:jar:3.6.0:compile
com.google.guava:guava:jar:25.1-jre:compile
 by org.apache.servicecomb:foundation-config:jar:1.2.0:compile
com.google.guava:guava:jar:26.0-jre:compile
 by org.openapitools:openapi-generator:jar:4.1.2:compile
com.google.guava:guava:jar:27.0.1-android:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile

commons-logging:commons-logging:jar:1.1.1:compile
 by org.apache.servicecomb:foundation-config:jar:1.2.0:compile
commons-logging:commons-logging:jar:1.2:compile
 by org.apache.logging.log4j:log4j-jcl:jar:2.3:compile

io.swagger:swagger-annotations:jar:1.5.22:compile
 by io.swagger:swagger-codegen:jar:2.4.3:compile
io.swagger:swagger-annotations:jar:1.5.23:compile
 by org.openapitools.swagger.parser:swagger-parser:jar:2.0.14-OpenAPITools.org-1:compile
io.swagger:swagger-annotations:jar:1.5.24:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile

io.swagger:swagger-compat-spec-parser:jar:1.0.43:compile
 by io.swagger:swagger-codegen:jar:2.4.3:compile
io.swagger:swagger-compat-spec-parser:jar:1.0.46:compile
 by org.openapitools:openapi-generator:jar:4.1.2:compile
io.swagger:swagger-compat-spec-parser:jar:1.0.47:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile

io.swagger:swagger-core:jar:1.5.22:compile
io.swagger:swagger-core:jar:1.5.23:compile
io.swagger:swagger-core:jar:1.5.24:compile

io.swagger:swagger-models:jar:1.5.22:compile
io.swagger:swagger-models:jar:1.5.23:compile
io.swagger:swagger-models:jar:1.5.24:compile

io.swagger:swagger-parser:jar:1.0.43:compile
io.swagger:swagger-parser:jar:1.0.46:compile
io.swagger:swagger-parser:jar:1.0.47:compile

org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile
 by org.openapitools:openapi-generator:jar:4.1.2:compile
org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile
 by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile

org.codehaus.plexus:plexus-archiver:jar:2.2:test
 by org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:3.3.0:test
org.codehaus.plexus:plexus-archiver:jar:3.6.0:compile
 by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile

org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
 by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile
org.codehaus.plexus:plexus-component-annotations:jar:1.7.1:test
 by org.apache.maven:maven-core:jar:3.6.0:test

org.codehaus.plexus:plexus-interpolation:jar:1.19:compile
 by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile
org.codehaus.plexus:plexus-interpolation:jar:1.25:test
 by org.apache.maven:maven-core:jar:3.6.0:test

org.codehaus.plexus:plexus-io:jar:2.0.4:test
 by org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:3.3.0:test
org.codehaus.plexus:plexus-io:jar:3.0.1:compile
 by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile

org.javassist:javassist:jar:3.18.1-GA:compile
 by org.apache.servicecomb:common-javassist:jar:1.2.0:compile
org.javassist:javassist:jar:3.19.0-GA:test
 by org.powermock:powermock-module-junit4:jar:1.6.2:test

}}

Since the CI is passed, so I'll leave it that way.
  


was (Author: chanjarster):
The dependency tree is complex, you can got two different version of 3rd-party through two different dependency paths.

I tried my best to unify the third party dependency versions, and below are the remaining inconsistent dependencies version:

{{com.atlassian.commonmark:commonmark:jar:0.11.0:compile }}
{{  by org.openapitools:openapi-generator:jar:4.1.2:compile}}
{{com.atlassian.commonmark:commonmark:jar:0.9.0:compile}}
{{  }}{{by io.swagger:swagger-codegen:jar:2.4.3}}{{com.google.code.findbugs:jsr305:jar:3.0.1:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}
{{com.google.code.findbugs:jsr305:jar:3.0.2:compile}}
{{  }}{{by org.apache.maven:maven-core:jar:3.6.0:compile}}{{com.google.errorprone:error_prone_annotations:jar:2.1.3:compile}}
{{  }}{{by org.apache.maven:maven-core:jar:3.6.0:compile}}
{{com.google.errorprone:error_prone_annotations:jar:2.2.0:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}{{com.google.guava:guava:jar:18.0:compile}}
{{  }}{{by io.airlift:airline:jar:0.7:compile}}
{{com.google.guava:guava:jar:25.1-android:compile}}
{{  }}{{by org.apache.maven:maven-core:jar:3.6.0:compile}}
{{com.google.guava:guava:jar:25.1-jre:compile}}
{{  }}{{by org.apache.servicecomb:foundation-config:jar:1.2.0:compile}}
{{com.google.guava:guava:jar:26.0-jre:compile}}
{{  }}{{by org.openapitools:openapi-generator:jar:4.1.2:compile}}
{{com.google.guava:guava:jar:27.0.1-android:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}{{commons-logging:commons-logging:jar:1.1.1:compile}}
{{  }}{{by org.apache.servicecomb:foundation-config:jar:1.2.0:compile}}
{{commons-logging:commons-logging:jar:1.2:compile}}
{{  }}{{by org.apache.logging.log4j:log4j-jcl:jar:2.3:compile}}{{io.swagger:swagger-annotations:jar:1.5.22:compile}}
{{  }}{{by io.swagger:swagger-codegen:jar:2.4.3:compile}}
{{io.swagger:swagger-annotations:jar:1.5.23:compile}}
{{  }}{{by org.openapitools.swagger.parser:swagger-parser:jar:2.0.14-OpenAPITools.org-1:compile}}
{{io.swagger:swagger-annotations:jar:1.5.24:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}{{io.swagger:swagger-compat-spec-parser:jar:1.0.43:compile}}
{{  }}{{by io.swagger:swagger-codegen:jar:2.4.3:compile}}
{{io.swagger:swagger-compat-spec-parser:jar:1.0.46:compile}}
{{  }}{{by org.openapitools:openapi-generator:jar:4.1.2:compile}}
{{io.swagger:swagger-compat-spec-parser:jar:1.0.47:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}{{io.swagger:swagger-core:jar:1.5.22:compile}}
{{io.swagger:swagger-core:jar:1.5.23:compile}}
{{io.swagger:swagger-core:jar:1.5.24:compile}}{{io.swagger:swagger-models:jar:1.5.22:compile}}
{{io.swagger:swagger-models:jar:1.5.23:compile}}
{{io.swagger:swagger-models:jar:1.5.24:compile}}{{io.swagger:swagger-parser:jar:1.0.43:compile}}
{{io.swagger:swagger-parser:jar:1.0.46:compile}}
{{io.swagger:swagger-parser:jar:1.0.47:compile}}{{org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile}}
{{  }}{{by org.openapitools:openapi-generator:jar:4.1.2:compile}}
{{org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile}}
{{  }}{{by io.swagger.parser.v3:swagger-parser:jar:2.0.15:compile}}{{org.codehaus.plexus:plexus-archiver:jar:2.2:test}}
{{  }}{{by org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:3.3.0:test}}
{{org.codehaus.plexus:plexus-archiver:jar:3.6.0:compile}}
{{  }}{{by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile}}{{org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile}}
{{  }}{{by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile}}
{{org.codehaus.plexus:plexus-component-annotations:jar:1.7.1:test}}
{{  }}{{by org.apache.maven:maven-core:jar:3.6.0:test}}{{org.codehaus.plexus:plexus-interpolation:jar:1.19:compile}}
{{  }}{{by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile}}
{{org.codehaus.plexus:plexus-interpolation:jar:1.25:test}}
{{  }}{{by org.apache.maven:maven-core:jar:3.6.0:test}}{{org.codehaus.plexus:plexus-io:jar:2.0.4:test}}
{{  }}{{by org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:3.3.0:test}}
{{org.codehaus.plexus:plexus-io:jar:3.0.1:compile}}
{{  }}{{by org.apache.maven.plugin-tools:maven-plugin-tools-annotations:jar:3.6.0:compile}}{{org.javassist:javassist:jar:3.18.1-GA:compile}}
{{  }}{{by org.apache.servicecomb:common-javassist:jar:1.2.0:compile}}
{{org.javassist:javassist:jar:3.19.0-GA:test}}
{{  }}{{by org.powermock:powermock-module-junit4:jar:1.6.2:test}}

Since the CI is passed, so I'll leave it that way.
 

> Cleanup third party dep version
> -------------------------------
>
>                 Key: SCB-1573
>                 URL: https://issues.apache.org/jira/browse/SCB-1573
>             Project: Apache ServiceComb
>          Issue Type: Task
>          Components: toolkit
>    Affects Versions: toolkit-0.2.0
>            Reporter: Daniel Qian
>            Assignee: Daniel Qian
>            Priority: Minor
>
> There are many duplicated third party deps but of different versions.
> Cleanup those deps and uniform the version.
> {{mvn dependency:list | sort | uniq }}will help you find duplicated third party deps
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)