[GitHub] [doris] Jibing-Li commented on a diff in pull request #20591: [fix](multi-catalog)fix s3 check, complete catalog properties

["Jibing-Li (via GitHub)" <gi...@apache.org>]

Jibing-Li commented on code in PR #20591:
URL: https://github.com/apache/doris/pull/20591#discussion_r1229339444


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java:
##########
@@ -153,6 +154,8 @@ public HivePartition load(PartitionCacheKey key) throws Exception {
      * generate a filecache and set to fileCacheRef
      */
     public void setNewFileCache() {
+        // init or refresh job conf
+        jobConf = getJobConf();

Review Comment:
   I'm not sure if this change will bring race condition or not. Because the reference of jobConf in getFilesByTransaction and loadFiles may be changed at any time. But I don't think it's a big problem since the refresh frequency is very low.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org