[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5248: Fix servers client methods changing call signatures

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #5248:
URL: https://github.com/apache/trafficcontrol/pull/5248#discussion_r518891741



##########
File path: lib/go-tc/servers.go
##########
@@ -574,11 +577,96 @@ func (s Server) ToNullable() ServerNullableV2 {
 	}
 }
 
+// ToNonNullable converts the ServerNullableV2 safely to a Server structure.
+func (s ServerNullableV2) ToNonNullable() Server {

Review comment:
       That just sounds like a stylistic choice. Other server conversion things are methods - like Upgrade and ToNullable - so I made this one as well.
   
   I think I made all of those too, so I think it's fair to say I prefer `server.Method()` over `Method(server)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org