[GitHub] [tvm] areusch commented on pull request #10493: [CMAKE,HEXAGON] Only use hexagon specific logging when building for hexagon

[GitBox <gi...@apache.org>]

areusch commented on pull request #10493:
URL: https://github.com/apache/tvm/pull/10493#issuecomment-1062033930


   i think if i understand this correctly--we currently need to build some hexagon files using two different build configs so that we can exercise some c++ unit tests on x86. we are attempting to turn on a hexagon simulator in the CI which could then host these tests--and then we could stop having two different compilation configs here, i think. this work needs the LLVM AOT codegen submitted in order to make progress there.
   
   i agree we should avoid defining `TVM_LOG_CUSTOMIZE` in source files, but perhaps given the medium-term solution further reduces the complexity by removing the multiple-compilation-config scenario, we should prefer that? the source files in question are not really designed to run on x86 anyways... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org