You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/10 19:46:36 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #1777: PoC: AsciiDoc extension to render list of extensions
ppalaga opened a new pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777
Rel #1557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-692636300
08ad76b:
* Reference tables ganerated using asciidoctor-antora-indexer AsciiDoc extension
* JVM since and Native since shown separately.
Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690888474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga edited a comment on pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-692656746
Follow ups:
* Remove `UpdateDocExtensionsListMojo`, its templates and config
* Discuss whether there is a better solution than having attribute-only `components/*.adoc` files. Those actually get transformed to dummy HTML pages that are accessible via HTTP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690888474
> Nice! I have most of a version using my extension working, but there are a couple glitches to solve. I had to extend my extension to camel-case attribute names in expressions, and haven't published the update yet. I hope to get it all working tomorrow.
Great!
> I don't understand where the "deprecated" comes from that gets counted above the table. If this is real, can it be added to the extension adoc page?
Of course, let me do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690885385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#discussion_r488599707
##########
File path: catalog/pom.xml
##########
@@ -4127,7 +4127,7 @@
<!-- prepare the catalog and update doc files, etc. -->
<goals>
<goal>prepare-catalog-quarkus</goal>
- <goal>update-doc-extensions-list</goal>
+ <!-- <goal>update-doc-extensions-list</goal> -->
Review comment:
Yes, I want to remove the whole mojo - see my commet above
> Remove UpdateDocExtensionsListMojo, its templates and config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-691335971
I made a PR against your branch, https://github.com/ppalaga/camel-quarkus/pull/5
I added a capability to the indexer extension to repeat a “template” block for each selected page, and wondered if it would be useful here. I added a second index page that uses this format, next to the one using a table. I think it would be easy to get stuff like the badges into the template, but I didn’t try. If we do this here, we should presumably do the same for the rest of the camel site.
We’ll need to update the main camel-website package.json to use the 0.0.5 version of the indexer extension.
I don’t understand how the styling for the status in the table is supposed to work…. I don’t see anything visibly different from it. Is there a css update pending somewhere?
David Jencks
> On Sep 10, 2020, at 11:17 PM, Peter Palaga <no...@github.com> wrote:
>
>
> 81b1de6 <https://github.com/apache/camel-quarkus/commit/81b1de6dc102f54a5873a8557016b4aa7500c38b> :
>
> Added cq-deprecated attribute to the extension pages.
> Removed the third commit so that you can eventually push your own commit to this branch. My original version is here for the reference: https://github.com/ppalaga/camel-quarkus/commits/i1557.1 <https://github.com/ppalaga/camel-quarkus/commits/i1557.1>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690899681>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXSTKA7WZ4L4662N2JLSFG6HHANCNFSM4RFXR76A>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#discussion_r488598980
##########
File path: catalog/pom.xml
##########
@@ -4127,7 +4127,7 @@
<!-- prepare the catalog and update doc files, etc. -->
<goals>
<goal>prepare-catalog-quarkus</goal>
- <goal>update-doc-extensions-list</goal>
+ <!-- <goal>update-doc-extensions-list</goal> -->
Review comment:
Can this be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690899681
81b1de6 :
* Added `cq-deprecated` attribute to the extension pages.
* Removed the third commit so that you can eventually push your own commit to this branch. My original version is here for the reference: https://github.com/ppalaga/camel-quarkus/commits/i1557.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690885385
Nice! I have most of a version using my extension working, but there are a couple glitches to solve. I had to extend my extension to camel-case attribute names in expressions, and haven't published the update yet. I hope to get it all working tomorrow.
I don't understand where the "deprecated" comes from that gets counted above the table. If this is real, can it be added to the extension adoc page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-691879930
Thanks @djencks , more inline
> I made a PR against your branch, [ppalaga#5](https://github.com/ppalaga/camel-quarkus/pull/5) I added a capability to the indexer extension to repeat a “template” block for each selected page, and wondered if it would be useful here.
Here a screenshot for the others to get an idea what it looks like:
It is an interesting experiment, but I must say, I like the existing table layout more. It takes less space and it is easier to scan visually. What do others think?
> I don’t understand how the styling for the status in the table is supposed to work…. I don’t see anything visibly different from it. Is there a css update pending somewhere?
No, I do not think there was supposed to be any special styling of the status in the table, at least not from me.
Unless somebody wants to veto, I'd extract the changes related to the extensions table from @djencks PR https://github.com/ppalaga/camel-quarkus/pull/5 and add them to this PR. The [extensions table](https://camel.apache.org/camel-quarkus/latest/reference/index.html) will thus look much like today, but will be powered by `@djencks/asciidoctor-antora-indexer` AsciiDoc extension.
I'll possibly add my work to display separate since versions for JVM and native on top of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-692656746
Follow ups:
* Remove `UpdateDocExtensionsListMojo`, its templates and config
* Discuss whether there is a better solution than having attribute-only `components/*.adoc` files that actually get transformed to HTML
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690885385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1777: Use asciidoctor-antora-indexer to produce lists of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-692310852
The block arrangement if condensed would take 3 lines per extension rather than what shows up as 2 lines for me, and I think looks a little nicer and more flowing for one extension, and I like the on-this-page TOC. However, I don't actually use this so my opinion is not all that valuable.
Since no one else has spoken in support of the block arrangement I'll take it out of my PR. It's easy enough to bring back should we change our minds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690885385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1777: PoC: AsciiDoc extension to render list of extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-690888474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org