You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jian Qiu <qi...@cn.ibm.com> on 2016/02/04 07:32:18 UTC
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 二月 4, 2016, 6:32 a.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Summary (updated)
-----------------
Speed up Speed up SlaveRecoveryTest.*.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description (updated)
-------
Speed up Speed up SlaveRecoveryTest.*.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review117773
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41787]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 4, 2016, 6:32 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:32 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
>
> Diff: https://reviews.apache.org/r/41787/diff/
>
>
> Testing
> -------
>
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review128065
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41787]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 11, 2016, 1:33 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 1:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests are sped up by using clock,
> while some relies on the fix of MESOS-4111 and a comment is put.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
>
> Diff: https://reviews.apache.org/r/41787/diff/
>
>
> Testing
> -------
>
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 四月 11, 2016, 1:33 a.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description (updated)
-------
Some tests are sped up by using clock,
while some relies on the fix of MESOS-4111 and a comment is put.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review128003
-----------------------------------------------------------
Bad patch!
Reviews applied: [41787]
Failed command: ./support/apply-review.sh -n -r 41787
Error:
2016-04-09 22:34:09 URL:https://reviews.apache.org/r/41787/diff/raw/ [7795/7795] -> "41787.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12431/console
- Mesos ReviewBot
On April 9, 2016, 3:42 p.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
>
> (Updated April 9, 2016, 3:42 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
>
> Diff: https://reviews.apache.org/r/41787/diff/
>
>
> Testing
> -------
>
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 四月 9, 2016, 3:42 p.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Summary (updated)
-----------------
Speed up SlaveRecoveryTest.*.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description (updated)
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs
-----
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 四月 9, 2016, 3:39 p.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Changes
-------
rebase
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description (updated)
-------
Speed up Speed up SlaveRecoveryTest.*.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 二月 4, 2016, 6:32 a.m.)
Review request for mesos, Alexander Rukletsov and Timothy Chen.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description (updated)
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs
-----
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu