You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2023/01/10 03:40:00 UTC
[jira] [Resolved] (ORC-1352) get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_UNIQUE_PTR
[ https://issues.apache.org/jira/browse/ORC-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun resolved ORC-1352.
--------------------------------
Fix Version/s: 1.9.0
Resolution: Fixed
Issue resolved by pull request 1368
[https://github.com/apache/orc/pull/1368]
> get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_UNIQUE_PTR
> ---------------------------------------------------------------
>
> Key: ORC-1352
> URL: https://issues.apache.org/jira/browse/ORC-1352
> Project: ORC
> Issue Type: Improvement
> Components: C++
> Affects Versions: 1.9.0
> Reporter: Junwang Zhao
> Assignee: Junwang Zhao
> Priority: Trivial
> Fix For: 1.9.0
>
>
> the following macros could be removed from the main source code to make the code neat.
> ```
> #define ORC_NOEXCEPT noexcept
> #define ORC_NULLPTR nullptr
> #define ORC_OVERRIDE override
> #define ORC_UNIQUE_PTR std::unique_ptr
> ```
> These macros should only be keeped in the `orc-config.hh.in` for backward compatiblity(in case any user use these marcros).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)