You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/10/15 11:27:26 UTC
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17928
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
IMPALA-10955: test_time_travel is flaky
test_time_travel is flaky. It's probably because one second
isn't always enough for Impala to refresh the Iceberg table
and return the results to the client when the system is busy.
Instead of one second now we are using 5 seconds.
Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
---
M tests/query_test/test_iceberg.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17928/1
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Oct 2021 08:36:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7548/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Oct 2021 08:36:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9616/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 14:15:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17928
to look at the new patch set (#2).
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
IMPALA-10955: test_time_travel is flaky
test_time_travel is flaky. It's probably because one second
isn't always enough for Impala to refresh the Iceberg table
and return the results to the client when the system is busy.
Instead of one second now we are using 5 seconds.
Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
---
M tests/query_test/test_iceberg.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17928/2
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Oct 2021 12:39:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178
PS1, Line 178: expect_results_t(cast_ts(ts_4) + " - interval 5 seconds", [])
I might have misunderstood something, but isn't the synchronization problem happening between 171-178, so if we postpone the timer 5s before the 4th DML the race condition remains.
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 10:11:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178
PS1, Line 178: expect_results_t(quote(ts_4), ['100'])
> Got it, thank you for the explanation.
`now() - ts_3 + 1s` wouldn't work, but I added `ts_3 + 1s`. If `ts_4 - 5s` remains flaky then probably we'll only keep ts_3+1s. Or we could retrieve the Iceberg timestamps from the table which would be the most robust solution.
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 13:57:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7544/
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Oct 2021 19:32:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178
PS1, Line 178: expect_results_t(cast_ts(ts_4) + " - interval 5 seconds", [])
> I might have misunderstood something, but isn't the synchronization problem
We use execute_query_ts which works the following way:
* executes query
* returns current timestamp
The Iceberg snapshot is being created during the INSERT statement at L171. After the snapshot is created it takes some time for Impala to reload the table and return the query results. If the machine is too busy then it might take more than one sec. Hopefully it won't take more than 5 seconds.
We need to sleep 5 seconds before the INSERT to make sure that traveling backwards 5 seconds from 'ts_4' will hit a timepoint after ts_3 but before ts_4 (when the table was empty).
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 13:20:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Oct 2021 17:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9607/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Oct 2021 11:49:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Oct 2021 14:45:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
IMPALA-10955: test_time_travel is flaky
test_time_travel is flaky. It's probably because one second
isn't always enough for Impala to refresh the Iceberg table
and return the results to the client when the system is busy.
Instead of one second now we are using 5 seconds.
Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Reviewed-on: http://gerrit.cloudera.org:8080/17928
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_iceberg.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178
PS1, Line 178: expect_results_t(quote(ts_4), ['100'])
> `now() - ts_3 + 1s` wouldn't work, but I added `ts_3 + 1s`. If `ts_4 - 5s`
Thanks for the update.
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 14:35:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7538/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Oct 2021 11:28:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7544/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Oct 2021 12:39:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Oct 2021 12:38:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10955: test time travel is flaky
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178
PS1, Line 178: expect_results_t(cast_ts(ts_4) + " - interval 5 seconds", [])
> We use execute_query_ts which works the following way:
Got it, thank you for the explanation.
This might be an overkill, but do you think it would make sense calculating the time in L178, something like `now() - ts_3 + 1s`?
--
To view, visit http://gerrit.cloudera.org:8080/17928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8
Gerrit-Change-Number: 17928
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 13:43:14 +0000
Gerrit-HasComments: Yes