You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Antoine Pitrou (JIRA)" <ji...@apache.org> on 2019/06/03 12:31:01 UTC

[jira] [Updated] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

     [ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Pitrou updated ARROW-3662:
----------------------------------
    Component/s: C++

> [C++] Add a const overload to MemoryMappedFile::GetSize
> -------------------------------------------------------
>
>                 Key: ARROW-3662
>                 URL: https://issues.apache.org/jira/browse/ARROW-3662
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++
>    Affects Versions: 0.11.1
>            Reporter: Dimitri Vorona
>            Assignee: Dimitri Vorona
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.12.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
>  
> While GetSize in general is not a const function, it can be on a MemoryMappedFile. I propose to add a const override directly to the MemoryMappedFile.
> Alternatively we could add a const version on the RandomAccessFile level which would fail, if a const size getting (e.g. without a seek) isn't possible, but it seems to me to be a potential source of hard-to-debug bugs and spurious failures. At would at least require a careful analysis of the platform support of different size getting options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)