You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ps...@apache.org on 2019/12/17 13:39:55 UTC
[hbase-connectors] branch master updated: HBASE-23586 Moved to
StandardCharsets in TestQualifierMatching (#56)
This is an automated email from the ASF dual-hosted git repository.
psomogyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase-connectors.git
The following commit(s) were added to refs/heads/master by this push:
new 2c73b5e HBASE-23586 Moved to StandardCharsets in TestQualifierMatching (#56)
2c73b5e is described below
commit 2c73b5e82a30cb4e3c3b7285935761641f34d23f
Author: Jan Hentschel <ja...@ultratendency.com>
AuthorDate: Tue Dec 17 14:39:49 2019 +0100
HBASE-23586 Moved to StandardCharsets in TestQualifierMatching (#56)
Signed-off-by: Peter Somogyi <ps...@apache.org>
---
.../hadoop/hbase/kafka/TestQualifierMatching.java | 47 +++++++++++-----------
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/kafka/hbase-kafka-proxy/src/test/java/org/apache/hadoop/hbase/kafka/TestQualifierMatching.java b/kafka/hbase-kafka-proxy/src/test/java/org/apache/hadoop/hbase/kafka/TestQualifierMatching.java
index 3e9ff36..dc9ec61 100644
--- a/kafka/hbase-kafka-proxy/src/test/java/org/apache/hadoop/hbase/kafka/TestQualifierMatching.java
+++ b/kafka/hbase-kafka-proxy/src/test/java/org/apache/hadoop/hbase/kafka/TestQualifierMatching.java
@@ -19,6 +19,8 @@ import org.junit.Assert;
import org.junit.Test;
import org.junit.experimental.categories.Category;
+import java.nio.charset.StandardCharsets;
+
/**
* Make sure match rules work
*/
@@ -26,48 +28,47 @@ import org.junit.experimental.categories.Category;
public class TestQualifierMatching {
@Test
- public void testMatchQualfier() throws Exception {
+ public void testMatchQualfier() {
DropRule rule = new DropRule();
- rule.setQualifier("data".getBytes("UTF-8"));
- Assert.assertTrue(rule.qualifierMatch("data".getBytes("UTF-8")));
+ rule.setQualifier("data".getBytes(StandardCharsets.UTF_8));
+ Assert.assertTrue(rule.qualifierMatch("data".getBytes(StandardCharsets.UTF_8)));
rule = new DropRule();
- rule.setQualifier("data1".getBytes("UTF-8"));
- Assert.assertFalse(rule.qualifierMatch("data".getBytes("UTF-8")));
+ rule.setQualifier("data1".getBytes(StandardCharsets.UTF_8));
+ Assert.assertFalse(rule.qualifierMatch("data".getBytes(StandardCharsets.UTF_8)));
// if not set, it is a wildcard
rule = new DropRule();
- Assert.assertTrue(rule.qualifierMatch("data".getBytes("UTF-8")));
+ Assert.assertTrue(rule.qualifierMatch("data".getBytes(StandardCharsets.UTF_8)));
}
@Test
- public void testStartWithQualifier() throws Exception{
+ public void testStartWithQualifier() {
DropRule rule = new DropRule();
- rule.setQualifier("data*".getBytes("UTF-8"));
+ rule.setQualifier("data*".getBytes(StandardCharsets.UTF_8));
Assert.assertTrue(rule.isQualifierStartsWith());
Assert.assertFalse(rule.isQualifierEndsWith());
- Assert.assertTrue(rule.qualifierMatch("data".getBytes("UTF-8")));
- Assert.assertTrue(rule.qualifierMatch("data1".getBytes("UTF-8")));
- Assert.assertTrue(rule.qualifierMatch("datafoobar".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("datfoobar".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("d".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("".getBytes("UTF-8")));
+ Assert.assertTrue(rule.qualifierMatch("data".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertTrue(rule.qualifierMatch("data1".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertTrue(rule.qualifierMatch("datafoobar".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("datfoobar".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("d".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("".getBytes(StandardCharsets.UTF_8)));
}
@Test
- public void testEndsWithQualifier() throws Exception {
+ public void testEndsWithQualifier() {
DropRule rule = new DropRule();
- rule.setQualifier("*data".getBytes("UTF-8"));
+ rule.setQualifier("*data".getBytes(StandardCharsets.UTF_8));
Assert.assertFalse(rule.isQualifierStartsWith());
Assert.assertTrue(rule.isQualifierEndsWith());
- Assert.assertTrue(rule.qualifierMatch("data".getBytes("UTF-8")));
- Assert.assertTrue(rule.qualifierMatch("1data".getBytes("UTF-8")));
- Assert.assertTrue(rule.qualifierMatch("foobardata".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("foobardat".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("d".getBytes("UTF-8")));
- Assert.assertFalse(rule.qualifierMatch("".getBytes("UTF-8")));
+ Assert.assertTrue(rule.qualifierMatch("data".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertTrue(rule.qualifierMatch("1data".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertTrue(rule.qualifierMatch("foobardata".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("foobardat".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("d".getBytes(StandardCharsets.UTF_8)));
+ Assert.assertFalse(rule.qualifierMatch("".getBytes(StandardCharsets.UTF_8)));
}
-
}