You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/27 01:47:28 UTC

[GitHub] [accumulo] ctubbsii commented on pull request #2718: Consolidate Root serialization code

ctubbsii commented on PR #2718:
URL: https://github.com/apache/accumulo/pull/2718#issuecomment-1139202825

   > > Allowed dropping of gson dependency from server.base
   > 
   > @milleruntime I didn't see a pom change related to this comment in the description
   
   I spoke with @milleruntime in person (well, virtually) while working through my code review, and part of my feedback was that the class shouldn't be relocated to a different jar (which was the reason the pom changed). I put it back in a subsequent commit that I appended to the PR, after discussing it with him.
   
   When this is squash-merged, I can clean up the log message for the commit. If not me, whoever merges it should clean up the commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org