[jira] [Commented] (LIBCLOUD-712) EC2 driver modifies region details

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545380#comment-14545380 ] 

ASF GitHub Bot commented on LIBCLOUD-712:
-----------------------------------------

GitHub user mvschaik opened a pull request:

    https://github.com/apache/libcloud/pull/523

    [LIBCLOUD-712] Use get() to take signature version

    The pop() call will remove the field from the REGION_DETAILS dictionary,
    causing subsequent calls to use the default value.
    
    Fixes https://issues.apache.org/jira/browse/LIBCLOUD-712

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud LIBCLOUD-712_fix-ec2-sigver

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #523
    
----
commit 8f2af00087fb2fb7617ecb7261af67a6c1cf0a50
Author: Maarten van Schaik <ma...@byte.nl>
Date:   2015-05-15T11:54:12Z

    [LIBCLOUD-712] Use get() to take signature version
    
    The pop() call will remove the field from the REGION_DETAILS dictionary,
    causing subsequent calls to use the default value.

----


> EC2 driver modifies region details
> ----------------------------------
>
>                 Key: LIBCLOUD-712
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-712
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: Maarten van Schaik
>
> When creating an EC2 connection, the signature version is taken from the region details using a pop-operation. This modifies the configuration: subsequent connections will not have the signature version available and will fall back to version 2.
> Example:
> {code}
> from libcloud.compute.drivers.ec2 import EC2NodeDriver
> drv = EC2NodeDriver('abc', region='eu-central-1')
> print drv.signature_version
> drv2 = EC2NodeDriver('abc', region='eu-central-1')
> print drv2.signature_version
> {code}
> Prints:
> {code}
> 4
> 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)