You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/20 11:50:58 UTC

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1082: fix: "method" can be null value

guoqqqi opened a new pull request #1082:
URL: https://github.com/apache/apisix-dashboard/pull/1082


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   resolve #784 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1082: feat: use selector to choose methods

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1082:
URL: https://github.com/apache/apisix-dashboard/pull/1082#issuecomment-748597684


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=h1) Report
   > Merging [#1082](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=desc) (d65115c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6c90ad340b566590187f2ade7e26310e18da0ac6?el=desc) (6c90ad3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1082/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1082   +/-   ##
   =======================================
     Coverage   40.25%   40.25%           
   =======================================
     Files          27       27           
     Lines        1627     1627           
   =======================================
     Hits          655      655           
     Misses        875      875           
     Partials       97       97           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=footer). Last update [6c90ad3...d65115c](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1082: feat: use selector to choose methods

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1082:
URL: https://github.com/apache/apisix-dashboard/pull/1082


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #1082: feat: "method" can be null value

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1082:
URL: https://github.com/apache/apisix-dashboard/pull/1082#issuecomment-748597684


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=h1) Report
   > Merging [#1082](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=desc) (07d6c0c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6c90ad340b566590187f2ade7e26310e18da0ac6?el=desc) (6c90ad3) will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1082/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1082      +/-   ##
   ==========================================
   - Coverage   40.25%   40.19%   -0.07%     
   ==========================================
     Files          27       27              
     Lines        1627     1627              
   ==========================================
   - Hits          655      654       -1     
   - Misses        875      876       +1     
     Partials       97       97              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1082/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=footer). Last update [6c90ad3...07d6c0c](https://codecov.io/gh/apache/apisix-dashboard/pull/1082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org