You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/05/26 13:56:42 UTC

[GitHub] [orc] mwlon opened a new pull request, #1142: minor documentation updates

mwlon opened a new pull request, #1142:
URL: https://github.com/apache/orc/pull/1142

   ### What changes were proposed in this pull request?
   Make docs and gitignore a bit more helpful for benchmark suite
   
   ### Why are the changes needed?
   * Benchmark `generate` command should not refer to itself as `convert`:
   ```$ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data --help
   usage: convert <root>
    -c,--compress <arg>   List of compression
    -d,--data <arg>       List of data sets
    -f,--format <arg>     List of formats
    -h,--help             Provide help
    -s,--sales <arg>      Number of records for sales```
    * README command for packaging the benchmark suite currently runs all tests; usually this is not necessary
    * benchmark generated data should be in .gitignore so that they are not accidentally added to git history
   
   ### How was this patch tested?
   No functionality or tests were modified
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun closed pull request #1142: ORC-1189: Update `README.md` and `help` command message in `benchmark` module and `.gitignore`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1142: ORC-1189: Update `README.md` and `help` command message in `benchmark` module and `.gitignore`
URL: https://github.com/apache/orc/pull/1142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] mwlon commented on pull request #1142: ORC-1189: Update `README.md` and `help` command message in `benchmark` module and `.gitignore`

Posted by GitBox <gi...@apache.org>.
mwlon commented on PR #1142:
URL: https://github.com/apache/orc/pull/1142#issuecomment-1138806723

   Thanks for the review, @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1142: ORC-1189: Update `README.md` and `help` command message in `benchmark` module and `.gitignore`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1142:
URL: https://github.com/apache/orc/pull/1142#issuecomment-1138794766

   Merged to main/1.8/1.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1142: ORC-1189: Update `README.md` and `help` command message in `benchmark` module and `.gitignore`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1142:
URL: https://github.com/apache/orc/pull/1142#issuecomment-1138795785

   I added you to the Apache ORC contributor group and assign ORC-1189 to you. Thank you again, @mwlon .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] mwlon commented on pull request #1142: minor documentation updates

Posted by GitBox <gi...@apache.org>.
mwlon commented on PR #1142:
URL: https://github.com/apache/orc/pull/1142#issuecomment-1138607139

   @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org