You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/11 19:33:29 UTC

[GitHub] [beam] robertwb commented on a change in pull request #14193: [BEAM-11715] [BEAM-11694] Re-enable (conditional) combiner packing.

robertwb commented on a change in pull request #14193:
URL: https://github.com/apache/beam/pull/14193#discussion_r592664521



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -494,11 +494,7 @@ def run_pipeline(self, pipeline, options):
       if pre_optimize == 'none' or pre_optimize == 'default':
         phases = []
       elif pre_optimize == 'all':
-        phases = [
-            # TODO(BEAM-11694): Enable translations.pack_combiners
-            # translations.pack_combiners,
-            translations.sort_stages
-        ]
+        phases = [translations.pack_combiners, translations.sort_stages]

Review comment:
       The goal is that it will by the time this release actually goes out. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org