You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Yuukirn (via GitHub)" <gi...@apache.org> on 2024/04/06 15:05:39 UTC
[PR] [WIP] Support idl for hessian2 [dubbo-go]
Yuukirn opened a new pull request, #2654:
URL: https://github.com/apache/dubbo-go/pull/2654
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2046650542
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj closed pull request #2654: [WIP] Support idl for hessian2
URL: https://github.com/apache/dubbo-go/pull/2654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2046626247
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2046649232
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "DMwangnima (via GitHub)" <gi...@apache.org>.
DMwangnima commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1554627219
##########
cmd/protoc-gen-go-hessian2/generate/generate.go:
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generate
+
+import (
+ "fmt"
+)
+
+import (
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/reflect/protoreflect"
+ "google.golang.org/protobuf/types/descriptorpb"
+)
+
+func GenHessian2(gen *protogen.Plugin, file *protogen.File) {
+ filename := file.GeneratedFilenamePrefix + ".hessian2.go"
+ g := gen.NewGeneratedFile(filename, file.GoImportPath)
+
+ g.P("package ", file.GoPackageName)
+ g.P()
+
+ g.P("import hessian \"github.com/apache/dubbo-go-hessian2\"")
+ g.P()
+
+ for _, message := range file.Messages {
+ genMessage(g, message)
+ }
+ genRegisterInitFunc(g, file)
+}
+
+func genMessage(g *protogen.GeneratedFile, m *protogen.Message) {
+ if m.Desc.IsMapEntry() {
+ return
+ }
+ g.AnnotateSymbol(m.GoIdent.String(), protogen.Annotation{
+ Location: m.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+
+ g.P("type ", m.GoIdent, " struct {")
+
+ genMessageFields(g, m)
+ g.P("}")
+ g.P()
+
+ genMessageRelatedMethods(g, m)
+}
+
+func genMessageFields(g *protogen.GeneratedFile, m *protogen.Message) {
+ for _, field := range m.Fields {
+ genMessageField(g, m, field)
+ }
+}
+
+func genMessageField(g *protogen.GeneratedFile, m *protogen.Message, field *protogen.Field) {
+ goType, pointer := fieldGoType(g, field)
+ if pointer {
+ goType = "*" + goType
+ }
+
+ name := field.GoName
+ g.AnnotateSymbol(m.GoIdent.GoName+"."+name, protogen.Annotation{
+ Location: field.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+ g.P(name, " ", goType)
+}
+
+func genMessageRelatedMethods(g *protogen.GeneratedFile, m *protogen.Message) {
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "JavaClassName() string {")
+ // TODO(Yuukirn): get class name by extend field
+ g.P(" return ", "\"org.test.service.", m.GoIdent.GoName, "\"")
+ g.P("}")
+
+ g.P()
+
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "String() string {")
Review Comment:
For now, we do not need this ```String()``` method since dubbo-go-hessian2 just make use of reflection to serialize.
In the future, we could generate serialization details to make it fast. (hessian2 FastCodec)
##########
cmd/protoc-gen-go-hessian2/generate/generate.go:
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generate
+
+import (
+ "fmt"
+)
+
+import (
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/reflect/protoreflect"
+ "google.golang.org/protobuf/types/descriptorpb"
+)
+
+func GenHessian2(gen *protogen.Plugin, file *protogen.File) {
+ filename := file.GeneratedFilenamePrefix + ".hessian2.go"
+ g := gen.NewGeneratedFile(filename, file.GoImportPath)
+
+ g.P("package ", file.GoPackageName)
+ g.P()
+
+ g.P("import hessian \"github.com/apache/dubbo-go-hessian2\"")
+ g.P()
+
+ for _, message := range file.Messages {
+ genMessage(g, message)
+ }
+ genRegisterInitFunc(g, file)
+}
+
+func genMessage(g *protogen.GeneratedFile, m *protogen.Message) {
+ if m.Desc.IsMapEntry() {
+ return
+ }
+ g.AnnotateSymbol(m.GoIdent.String(), protogen.Annotation{
+ Location: m.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+
+ g.P("type ", m.GoIdent, " struct {")
+
+ genMessageFields(g, m)
+ g.P("}")
+ g.P()
+
+ genMessageRelatedMethods(g, m)
+}
+
+func genMessageFields(g *protogen.GeneratedFile, m *protogen.Message) {
+ for _, field := range m.Fields {
+ genMessageField(g, m, field)
+ }
+}
+
+func genMessageField(g *protogen.GeneratedFile, m *protogen.Message, field *protogen.Field) {
+ goType, pointer := fieldGoType(g, field)
+ if pointer {
+ goType = "*" + goType
+ }
+
+ name := field.GoName
+ g.AnnotateSymbol(m.GoIdent.GoName+"."+name, protogen.Annotation{
+ Location: field.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+ g.P(name, " ", goType)
+}
+
+func genMessageRelatedMethods(g *protogen.GeneratedFile, m *protogen.Message) {
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "JavaClassName() string {")
+ // TODO(Yuukirn): get class name by extend field
+ g.P(" return ", "\"org.test.service.", m.GoIdent.GoName, "\"")
+ g.P("}")
+
+ g.P()
+
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "String() string {")
+ g.P(" e := hessian.NewEncoder()")
+ g.P(" err := e.Encode(x)")
+ g.P(" if err != nil {")
+ g.P(" return \"\"")
+ g.P(" }")
+ g.P(" return string(e.Buffer())")
+ g.P("}")
+ g.P()
+}
+
+func genRegisterInitFunc(g *protogen.GeneratedFile, f *protogen.File) {
+ g.P("func init() {")
+ for _, message := range f.Messages {
+ g.P("hessian.RegisterPOJO(new(", message.GoIdent.GoName, "))")
+ }
+ g.P("}")
+ g.P()
+}
+
+// fieldGoType returns the Go type used for a field.
+//
+// If it returns pointer=true, the struct field is a pointer to the type.
+func fieldGoType(g *protogen.GeneratedFile, field *protogen.Field) (goType string, pointer bool) {
+ if field.Desc.IsWeak() {
+ return "struct{}", false
+ }
+
+ pointer = field.Desc.HasPresence()
+ switch field.Desc.Kind() {
Review Comment:
We should discuss the mappings in details.
type serialization conversion: proto type => go type => java type
helping tool conversion: java interface file => proto file
e.g. Java does not support unsigned basic type, it would be complex when implementing helping tool if we decide to support unsigned basic type in proto and go.
##########
cmd/protoc-gen-go-hessian2/generate/generate.go:
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generate
+
+import (
+ "fmt"
+)
+
+import (
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/reflect/protoreflect"
+ "google.golang.org/protobuf/types/descriptorpb"
+)
+
+func GenHessian2(gen *protogen.Plugin, file *protogen.File) {
+ filename := file.GeneratedFilenamePrefix + ".hessian2.go"
+ g := gen.NewGeneratedFile(filename, file.GoImportPath)
+
+ g.P("package ", file.GoPackageName)
+ g.P()
+
+ g.P("import hessian \"github.com/apache/dubbo-go-hessian2\"")
+ g.P()
+
+ for _, message := range file.Messages {
+ genMessage(g, message)
+ }
+ genRegisterInitFunc(g, file)
+}
+
+func genMessage(g *protogen.GeneratedFile, m *protogen.Message) {
+ if m.Desc.IsMapEntry() {
+ return
+ }
+ g.AnnotateSymbol(m.GoIdent.String(), protogen.Annotation{
+ Location: m.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+
+ g.P("type ", m.GoIdent, " struct {")
+
+ genMessageFields(g, m)
+ g.P("}")
+ g.P()
+
+ genMessageRelatedMethods(g, m)
+}
+
+func genMessageFields(g *protogen.GeneratedFile, m *protogen.Message) {
+ for _, field := range m.Fields {
+ genMessageField(g, m, field)
+ }
+}
+
+func genMessageField(g *protogen.GeneratedFile, m *protogen.Message, field *protogen.Field) {
+ goType, pointer := fieldGoType(g, field)
+ if pointer {
+ goType = "*" + goType
+ }
+
+ name := field.GoName
+ g.AnnotateSymbol(m.GoIdent.GoName+"."+name, protogen.Annotation{
+ Location: field.Location,
+ Semantic: descriptorpb.GeneratedCodeInfo_Annotation_SET.Enum(),
+ })
+ g.P(name, " ", goType)
+}
+
+func genMessageRelatedMethods(g *protogen.GeneratedFile, m *protogen.Message) {
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "JavaClassName() string {")
+ // TODO(Yuukirn): get class name by extend field
+ g.P(" return ", "\"org.test.service.", m.GoIdent.GoName, "\"")
+ g.P("}")
+
+ g.P()
+
+ g.P("func ", "(x *", m.GoIdent.GoName, ")", "String() string {")
+ g.P(" e := hessian.NewEncoder()")
+ g.P(" err := e.Encode(x)")
+ g.P(" if err != nil {")
+ g.P(" return \"\"")
+ g.P(" }")
+ g.P(" return string(e.Buffer())")
+ g.P("}")
+ g.P()
+}
+
+func genRegisterInitFunc(g *protogen.GeneratedFile, f *protogen.File) {
+ g.P("func init() {")
+ for _, message := range f.Messages {
+ g.P("hessian.RegisterPOJO(new(", message.GoIdent.GoName, "))")
+ }
+ g.P("}")
+ g.P()
+}
+
+// fieldGoType returns the Go type used for a field.
+//
+// If it returns pointer=true, the struct field is a pointer to the type.
+func fieldGoType(g *protogen.GeneratedFile, field *protogen.Field) (goType string, pointer bool) {
Review Comment:
Maybe ```isPointer``` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2113944842
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [14 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [6.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041113460
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "DMwangnima (via GitHub)" <gi...@apache.org>.
DMwangnima commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041118835
Should we create a unique branch to track this working process. cc @chickenlj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "Yuukirn (via GitHub)" <gi...@apache.org>.
Yuukirn commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1573180552
##########
cmd/protoc-gen-go-dubbo/gen/generator/gen_dubbo.go:
##########
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generator
+
+import (
+ "fmt"
+)
+
+import (
+ "github.com/pkg/errors"
+
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/proto"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/cmd/protoc-gen-go-dubbo/util"
+ "dubbo.apache.org/dubbo-go/v3/proto/hessian2_extend"
+)
+
+var (
+ ErrStreamMethod = errors.New("dubbo doesn't support stream method")
+ ErrMoreExtendArgsRespFieldNum = errors.New("extend args for response message should only has 1 field")
+ ErrNoExtendArgsRespFieldNum = errors.New("extend args for response message should has a field")
+)
+
+type DubboGo struct {
Review Comment:
fixed
##########
cmd/protoc-gen-go-dubbo/gen/generator/generator.go:
##########
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generator
+
+import (
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2049715212
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1602549021
##########
cmd/protoc-gen-go-dubbo/gen/generator/gen_dubbo.go:
##########
@@ -22,15 +22,14 @@ import (
)
import (
+ "dubbo.apache.org/dubbo-go/v3/proto/hessian2_extend"
Review Comment:
挪到第三个 import 里面
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2067578161
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [14 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [7.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2046731515
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2054160416
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1572148833
##########
cmd/protoc-gen-go-dubbo/gen/generator/gen_dubbo.go:
##########
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generator
+
+import (
+ "fmt"
+)
+
+import (
+ "github.com/pkg/errors"
+
+ "google.golang.org/protobuf/compiler/protogen"
+ "google.golang.org/protobuf/proto"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/cmd/protoc-gen-go-dubbo/util"
+ "dubbo.apache.org/dubbo-go/v3/proto/hessian2_extend"
+)
+
+var (
+ ErrStreamMethod = errors.New("dubbo doesn't support stream method")
+ ErrMoreExtendArgsRespFieldNum = errors.New("extend args for response message should only has 1 field")
+ ErrNoExtendArgsRespFieldNum = errors.New("extend args for response message should has a field")
+)
+
+type DubboGo struct {
Review Comment:
Dubbogo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2041117492
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.39%. Comparing base [(`2f5143a`)](https://app.codecov.io/gh/apache/dubbo-go/commit/2f5143a2acf4d420d2b93555a85021295bfe86f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b22996a`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on main.
> :exclamation: Current head b22996a differs from pull request most recent head d8ab177. Consider uploading reports for the commit d8ab177 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 47.38% 47.39%
=======================================
Files 341 341
Lines 25122 25125 +3
=======================================
+ Hits 11904 11907 +3
+ Misses 12074 12072 -2
- Partials 1144 1146 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2654?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2054150067
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2057531748
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2054159638
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#discussion_r1572149260
##########
cmd/protoc-gen-go-dubbo/gen/generator/generator.go:
##########
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package generator
+
+import (
Review Comment:
用工具格式化下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2066106643
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654) **Quality Gate passed**
Issues
 [14 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2654&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [7.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2654&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [WIP] Support idl for hessian2 [dubbo-go]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #2654:
URL: https://github.com/apache/dubbo-go/pull/2654#issuecomment-2114701396
Please submit a new pull request to https://github.com/dubbogo/protoc-gen-go-triple/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org