You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by ajaybhat <gi...@git.apache.org> on 2014/05/06 15:07:17 UTC
[GitHub] incubator-drill pull request: Commit ID : ddda597b9072ec0f5e1cbf10...
GitHub user ajaybhat opened a pull request:
https://github.com/apache/incubator-drill/pull/64
Commit ID : ddda597b9072ec0f5e1cbf10b4f5519d21ca31f8
DRILL-182 Added Math implementations abs,ceil,floor,signum,sqrt
Signed-off-by: Ajay Bhat <a....@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajaybhat/incubator-drill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-drill/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 5d57ef9deb2369bd507026da013a11b685a7bfc4
Author: Ajay Bhat <a....@gmail.com>
Date: 2014-05-06T13:02:16Z
Commit ID : ddda597b9072ec0f5e1cbf10b4f5519d21ca31f8
DRILL-182 Added Math implementations abs,ceil,floor,signum,sqrt
Signed-off-by: Ajay Bhat <a....@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-drill pull request: Adding Math function implementations
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-drill/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-drill pull request: DRILL-182 Add abs() implementation
Posted by Yash Sharma <ya...@gmail.com>.
It would be great if we update this document link in the Wki Page:
https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Whereisagoodplacetostartcontributing
?
It has got the old document there.
Peace,
Yash
On Wed, May 7, 2014 at 12:41 AM, mehant <gi...@git.apache.org> wrote:
> Github user mehant commented on the pull request:
>
>
> https://github.com/apache/incubator-drill/pull/64#issuecomment-42345668
>
> Yes we have a pending patch for Trignometric functions. It would be
> good if you can create a JIRA for the set of functions you are working on
> to avoid duplicating effort.
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-drill pull request: DRILL-182 Add abs() implementation
Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on the pull request:
https://github.com/apache/incubator-drill/pull/64#issuecomment-42345668
Yes we have a pending patch for Trignometric functions. It would be good if you can create a JIRA for the set of functions you are working on to avoid duplicating effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-drill pull request: DRILL-182 Add abs() implementation
Posted by ajaybhat <gi...@git.apache.org>.
Github user ajaybhat commented on the pull request:
https://github.com/apache/incubator-drill/pull/64#issuecomment-42345197
Thanks for the link. I'd seen the template already, but I didn't know if that and the implementations in Java were separate. I'll get to work on the functions in the spreadsheet. If I'm not wrong, the trigo functions have been implemented and need to be committed (DRILL-219)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-drill pull request: DRILL-182 Add abs() implementation
Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on the pull request:
https://github.com/apache/incubator-drill/pull/64#issuecomment-42344533
Hey Ajay,
Thanks for the patch but we have these math functions implemented. We use freemarker template to generate these functions for all the data types. Here is a spread sheet with functions that haven't been implemented yet : https://docs.google.com/spreadsheet/ccc?key=0AgAGbQ6asvQ-dDRrUUxVSVlMVXRtanRoWk9JcHgteUE&usp=drive_web#gid=0
It would be great if you can get some of these implemented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---