[lucene-solr] branch reference_impl_dev updated: @450 Remove out of place check that you cant create a core with no node name.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new 6b157c9  @450 Remove out of place check that you cant create a core with no node name.
6b157c9 is described below

commit 6b157c9f36005735e8638f27f92f55c6aa04fd21
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 28 23:04:06 2020 -0500

    @450 Remove out of place check that you cant create a core with no node name.
---
 .../solr/cloud/DeleteInactiveReplicaTest.java      | 33 ++++++++++------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
index 0705511..8c98791 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
@@ -75,8 +75,6 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
     }
     cluster.stopJettySolrRunner(jetty);
 
-    cluster.waitForJettyToStop(jetty);
-
     waitForState("Expected replica " + replica.getName() + " on down node to be removed from cluster state", collectionName, (n, c) -> {
       Replica r = c.getReplica(replica.getCoreName());
       return r == null || r.getState() != Replica.State.ACTIVE;
@@ -91,21 +89,20 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
       return c.getReplica(replica.getCoreName()) == null;
     });
 
-    cluster.startJettySolrRunner(jetty);
-    log.info("restarted jetty");
-
-    // Check that we can't create a core with no coreNodeName
-    try (SolrClient queryClient = getHttpSolrClient(jetty.getBaseUrl().toString())) {
-      Exception e = expectThrows(Exception.class, () -> {
-        CoreAdminRequest.Create createRequest = new CoreAdminRequest.Create();
-        createRequest.setCoreName("testcore");
-        createRequest.setCollection(collectionName);
-        createRequest.setShardId("shard2");
-        queryClient.request(createRequest);
-      });
-      assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("No coreNodeName for"));
-
-    }
+//    cluster.startJettySolrRunner(jetty);
+//    log.info("restarted jetty");
+//
+//    // Check that we can't create a core with no coreNodeName
+//    try (SolrClient queryClient = getHttpSolrClient(jetty.getBaseUrl().toString())) {
+//      Exception e = expectThrows(Exception.class, () -> {
+//        CoreAdminRequest.Create createRequest = new CoreAdminRequest.Create();
+//        createRequest.setCoreName("testcore");
+//        createRequest.setCollection(collectionName);
+//        createRequest.setShardId("shard2");
+//        queryClient.request(createRequest);
+//      });
+//      assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("No coreNodeName for"));
+//
+//    }
   }
-
 }