You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/25 20:14:45 UTC
[GitHub] john-bodley opened a new pull request #6942: [SQL Lab] Removing
display limit
john-bodley opened a new pull request #6942: [SQL Lab] Removing display limit
URL: https://github.com/apache/incubator-superset/pull/6942
We're run into issues were users in SQL Lab are expecting the number of records to be displayed to equal that of the `LIMIT` defined either in i) the SQL query, or ii) the UI limit component, however this is truncated to display only the default limit, and there's no mention of this to the user. Note when exporting to CSV the display limit is not applied.
Given that the `LIMIT` has been applied (defaulting to the `DEFAULT_SQLLAB_LIMIT` if neither the query or UI component have been augmented) it seems prudent to not re-apply any additional limit when displaying the results.
to: @jeffreythewang @michellethomas @mistercrunch @timifasubaa
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org