[jira] [Comment Edited] (HIVE-18825) Define ValidTxnList before starting query optimization

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381517#comment-16381517 ] 

Gopal V edited comment on HIVE-18825 at 3/1/18 4:56 AM:
--------------------------------------------------------

{code}

assert isTxnOpen();


java.lang.AssertionError
	at org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.getValidTxns(DbTxnManager.java:763)
	at org.apache.hadoop.hive.ql.Driver.recordValidTxns(Driver.java:1223)
	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:610)
{code}


was (Author: gopalv):
{code}
java.lang.AssertionError
	at org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.getValidTxns(DbTxnManager.java:763)
	at org.apache.hadoop.hive.ql.Driver.recordValidTxns(Driver.java:1223)
	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:610)
{code}

> Define ValidTxnList before starting query optimization
> ------------------------------------------------------
>
>                 Key: HIVE-18825
>                 URL: https://issues.apache.org/jira/browse/HIVE-18825
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>         Attachments: HIVE-18825.patch
>
>
> Consider a set of tables used by a materialized view where inserts happened after the materialization was created. To compute incremental view maintenance, we need to be able to filter only new rows from those base tables. That can be done by inserting a filter operator with condition e.g. {{ROW\_\_ID.transactionId < highwatermark and ROW\_\_ID.transactionId NOT IN(<open txns>)}} on top of the MVs query definition and triggering the rewriting (which should in turn produce a partial rewriting). However, to do that, we need to have a value for {{ValidTxnList}} during query compilation so we know the snapshot that we are querying.
> This patch aims to generate {{ValidTxnList}} before query optimization. There should not be any visible changes for end user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)