[GitHub] [couchdb] davisp commented on a change in pull request #3105: bypass partition query limit for mango

[GitBox <gi...@apache.org>]

davisp commented on a change in pull request #3105:
URL: https://github.com/apache/couchdb/pull/3105#discussion_r478536289



##########
File path: test/elixir/test/partition_mango_test.exs
##########
@@ -502,6 +502,9 @@ defmodule PartitionMangoTest do
     create_partition_docs(db_name)
     create_index(db_name, ["value"])
 
+    # this is to test that we bypass partition_query_limit for mango
+    set_config({"query_server_config", "partition_query_limit", "1"})
+

Review comment:
       Lets create a specific test for this rather than mixing our assertions.

##########
File path: src/mango/src/mango_cursor_view.erl
##########
@@ -116,7 +116,8 @@ base_args(#cursor{index = Idx, selector = Selector} = Cursor) ->
         start_key = StartKey,
         end_key = EndKey,
         include_docs = true,
-        extra = [{callback, {?MODULE, view_cb}}, {selector, Selector}]
+        extra = [{callback, {?MODULE, view_cb}}, {selector, Selector},

Review comment:
       Style nit, but make this multi-lined:
   
   ```erlang
   extra = [
       {callback, {?MODULE, view_cb}},
       {selector, Selector},
       {ignore_partition_query_limit, true}
   ]
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org