You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/06 20:46:39 UTC
[GitHub] [kibble] turbaszek opened a new issue #37: Consider moving /setup content to main directory
turbaszek opened a new issue #37:
URL: https://github.com/apache/kibble/issues/37
It's rather uncommon to keep setup.py and requirements.txt in a separate directory so I would like to suggest moving it to main directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-704543557
@Humbedooh what do you think? Is there any reason for keeping it in /setup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] michalslowikowski00 commented on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-707597343
Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek closed issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek closed issue #37:
URL: https://github.com/apache/kibble/issues/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] michalslowikowski00 commented on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-707331816
Is it still valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-707338899
@michalslowikowski00 I think we should still consider this idea. As a first step, it would be good to figure what is in `setup/makeaccount.py` and structure this file a little bit. This seems to be a script that accepts some users input. I think it may make sense to refactor it and then introduce `kibble.py` with argparser that would serve the purpose of both `setup.py` and `makeaccount.py` (probably two sub commands?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek edited a comment on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-707338899
@michalslowikowski00 I think we should still consider this idea. As a first step, I would suggest to figure what is in `setup/makeaccount.py` and structure this file a little bit. This seems to be a script that accepts some users input. I think it may make sense to refactor it and then introduce `kibble.py` with argparser that would serve the purpose of both `setup.py` and `makeaccount.py` (probably two sub commands?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-704549908
Slightly related #38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek edited a comment on issue #37: Consider moving /setup content to main directory
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on issue #37:
URL: https://github.com/apache/kibble/issues/37#issuecomment-707338899
@michalslowikowski00 I think we should still consider this idea. As a first step, I would suggest figuring what is in `setup/makeaccount.py` and structure this file a little bit. This seems to be a script that accepts some users' input. I think it may make sense to refactor it and then introduce `kibble.py` with argparser that would serve the purpose of both `setup.py` and `makeaccount.py` (probably two subcommands?), for example:
```
# instead of: python setup.py
python kibble.py setup -e elasticsearch -a -k
# instead of: python makeaccount.py
python kibble.py make_account -a
```
This would be a nice step toward making kibble a python package (see #38 ) so in the future users could simply do
```
kibble setup
kibble make_account
```
What do you think @sharanf @Humbedooh ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org