You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/12 17:52:51 UTC
[GitHub] [kafka] hachikuji opened a new pull request, #12624: KAFKA-14215; Ensure forwarded requests are applied to broker request quota
hachikuji opened a new pull request, #12624:
URL: https://github.com/apache/kafka/pull/12624
Currently forwarded requests are not applied to any quotas on either the controller or the broker. The controller-side throttling requires the controller to apply the quota changes from the log to the quota managers, which will be done separately. In this patch, we change the response logic on the broker side to also apply the broker's request quota. The enforced throttle time is the maximum of the throttle returned from the controller (which is 0 until we fix the aforementioned issue) and the broker's request throttle time.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a diff in pull request #12624: KAFKA-14215; Ensure forwarded requests are applied to broker request quota
Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12624:
URL: https://github.com/apache/kafka/pull/12624#discussion_r968967605
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -268,6 +268,8 @@ public ApiKeys apiKey() {
public abstract int throttleTimeMs();
+ public abstract void setThrottleTimeMs(int throttleTimeMs);
Review Comment:
Makes sense. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12624: KAFKA-14215; Ensure forwarded requests are applied to broker request quota
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12624:
URL: https://github.com/apache/kafka/pull/12624#issuecomment-1244563584
@mumrah Thanks for reviewing. Note that the controller will not actually be applying the throttles in the future since it does not have a direct client connection to throttle. The intention is just to let it set the throttle value and to have the broker throttle the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #12624: KAFKA-14215; Ensure forwarded requests are applied to broker request quota
Posted by GitBox <gi...@apache.org>.
mumrah commented on code in PR #12624:
URL: https://github.com/apache/kafka/pull/12624#discussion_r968961932
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -268,6 +268,8 @@ public ApiKeys apiKey() {
public abstract int throttleTimeMs();
+ public abstract void setThrottleTimeMs(int throttleTimeMs);
Review Comment:
How about `maybeSetThrottleTimeMs` since not all response schemas support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12624: KAFKA-14215; Ensure forwarded requests are applied to broker request quota
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12624:
URL: https://github.com/apache/kafka/pull/12624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org