You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2007/05/06 17:36:15 UTC
[jira] Commented: (HTTPCORE-21) have connections count requests
[ https://issues.apache.org/jira/browse/HTTPCORE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493934 ]
Oleg Kalnichevski commented on HTTPCORE-21:
-------------------------------------------
Hi Andrea,
Great! Many thanks for taking up this issue. Just a few comments / ideas to consider
* I think byte counts (bytes sent / bytes received) should be moved to HttpDataTransmitter / HttpDataReceiver because there those counts would be easier to implement and be made more reliable. I would suggest introducing an optional interface for that end (or something similar) and making SocketHttpDataTransmitter / SocketHttpDataReceiver implement it
interface HttpTransportMetrics {
long getBytesTransferred();
}
* For performance reasons I would suggest using longs for keeping the four main counts in order to avoid the costs of object casing and map access. This will make the HttpConnectionMetricsImpl code somewhat uglier but will help reduce performance overhead of connection metrics.
Oleg
> have connections count requests
> -------------------------------
>
> Key: HTTPCORE-21
> URL: https://issues.apache.org/jira/browse/HTTPCORE-21
> Project: HttpComponents Core
> Issue Type: Wish
> Components: HttpCore
> Affects Versions: 4.0-alpha3
> Reporter: Roland Weber
> Priority: Minor
> Fix For: 4.0-alpha5
>
> Attachments: 2k6-12-28-reqcnt-1.txt, metrics.patch
>
>
> It would be nice if connections would count the requests sent since they were opened. This would greatly simplify the implementation of reuse strategies like "reuse for at most 5 requests". While it is possible to count requests elsewhere, that is clumsy and error prone. For example the HttpContext is not a good place to keep the request count, since the connection may be released to and re-acquired from a connection manager, so the previously used context is lost.
> patch follows
> cheers,
> Roland
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org