You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wilder Rodrigues <wr...@schubergphilis.com> on 2013/11/08 15:40:55 UTC

Review Request 15351: Fixing bugs from Coverity related to Dereferenced Null after check and as return value.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15351/
-----------------------------------------------------------

Review request for cloudstack and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

Fixing Coverity bugs with IDs: cv_1125361, cv_1125357, cv_1125356, cv_1125355, cv_1117769, cv_1125354, cv_1125353, cv_1125346, cv_1125352, cv_1125360 


Diffs
-----

  agent/src/com/cloud/agent/AgentShell.java 900a13f 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java 063db0e 
  server/src/com/cloud/server/ConfigurationServerImpl.java 0676db8 
  utils/src/com/cloud/utils/nio/Link.java 4b041f5 

Diff: https://reviews.apache.org/r/15351/diff/


Testing
-------

All tests passed during build.

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:19.357s
[INFO] Finished at: Fri Nov 08 15:06:34 CET 2013
[INFO] Final Memory: 68M/163M


Thanks,

Wilder Rodrigues


Re: Review Request 15351: Fixing bugs from Coverity related to Dereferenced Null after check and as return value.

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15351/#review29480
-----------------------------------------------------------

Ship it!


2774b62d64989bddc1e4664ef7a93dff11c77657

- daan Hoogland


On Nov. 25, 2013, 11:02 a.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15351/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 11:02 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing Coverity bugs with IDs: cv_1125361, cv_1125357, cv_1125356, cv_1125355, cv_1117769, cv_1125354, cv_1125353, cv_1125346, cv_1125352, cv_1125360 
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/AgentShell.java 936e3cd 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java ca44757 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 32d5d93 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java 129392e 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
>   utils/src/com/cloud/utils/nio/Link.java 3b30053 
> 
> Diff: https://reviews.apache.org/r/15351/diff/
> 
> 
> Testing
> -------
> 
> All tests passed during build.
> 
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 10:19.357s
> [INFO] Finished at: Fri Nov 08 15:06:34 CET 2013
> [INFO] Final Memory: 68M/163M
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Re: Review Request 15351: Fixing bugs from Coverity related to Dereferenced Null after check and as return value.

Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15351/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 11:02 a.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
-------

Rebasing the patch with latest updates from Alex.


Repository: cloudstack-git


Description
-------

Fixing Coverity bugs with IDs: cv_1125361, cv_1125357, cv_1125356, cv_1125355, cv_1117769, cv_1125354, cv_1125353, cv_1125346, cv_1125352, cv_1125360 


Diffs (updated)
-----

  agent/src/com/cloud/agent/AgentShell.java 936e3cd 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java ca44757 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 32d5d93 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java 129392e 
  server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
  utils/src/com/cloud/utils/nio/Link.java 3b30053 

Diff: https://reviews.apache.org/r/15351/diff/


Testing
-------

All tests passed during build.

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:19.357s
[INFO] Finished at: Fri Nov 08 15:06:34 CET 2013
[INFO] Final Memory: 68M/163M


Thanks,

Wilder Rodrigues