You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2007/08/22 15:14:30 UTC
[jira] Created: (DIRMINA-427) Creating a common EventType enum
Creating a common EventType enum
---------------------------------
Key: DIRMINA-427
URL: https://issues.apache.org/jira/browse/DIRMINA-427
Project: MINA
Issue Type: Improvement
Affects Versions: 1.1.2
Reporter: Emmanuel Lecharny
Priority: Minor
I have migrated the EventType class found in VmPipeFilterChain and ExecutorFilter to core/src/main/java/org/apache/mina/common/EventType.java, and it's now an enum. It is easier to use, as you don't have to do a cascade if/then/else in the ExecutorFilter and VmPipeFilterChain classes, they are replaced by a switch( eventType ).
See the diff attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-427) Creating a common EventType enum
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRMINA-427:
--------------------------------------
Attachment: mina-with-enum.diff
EventType as an enum and externalized in its own file.
> Creating a common EventType enum
> ---------------------------------
>
> Key: DIRMINA-427
> URL: https://issues.apache.org/jira/browse/DIRMINA-427
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 1.1.2
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Attachments: mina-with-enum.diff
>
>
> I have migrated the EventType class found in VmPipeFilterChain and ExecutorFilter to core/src/main/java/org/apache/mina/common/EventType.java, and it's now an enum. It is easier to use, as you don't have to do a cascade if/then/else in the ExecutorFilter and VmPipeFilterChain classes, they are replaced by a switch( eventType ).
> See the diff attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-427) Creating a common EventType enum
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRMINA-427.
-------------------------------------
definitively already done ... Doh !
> Creating a common EventType enum
> ---------------------------------
>
> Key: DIRMINA-427
> URL: https://issues.apache.org/jira/browse/DIRMINA-427
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 1.1.2
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Attachments: mina-with-enum.diff
>
>
> I have migrated the EventType class found in VmPipeFilterChain and ExecutorFilter to core/src/main/java/org/apache/mina/common/EventType.java, and it's now an enum. It is easier to use, as you don't have to do a cascade if/then/else in the ExecutorFilter and VmPipeFilterChain classes, they are replaced by a switch( eventType ).
> See the diff attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-427) Creating a common EventType enum
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee resolved DIRMINA-427.
---------------------------------
Resolution: Duplicate
It's duplicate of DIRMINA-361. Will fix in 2.0.0-M1.
> Creating a common EventType enum
> ---------------------------------
>
> Key: DIRMINA-427
> URL: https://issues.apache.org/jira/browse/DIRMINA-427
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 1.1.2
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Attachments: mina-with-enum.diff
>
>
> I have migrated the EventType class found in VmPipeFilterChain and ExecutorFilter to core/src/main/java/org/apache/mina/common/EventType.java, and it's now an enum. It is easier to use, as you don't have to do a cascade if/then/else in the ExecutorFilter and VmPipeFilterChain classes, they are replaced by a switch( eventType ).
> See the diff attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.