You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by Raymie Stata <rs...@yahoo.com.INVALID> on 2018/10/24 07:13:30 UTC

Bad test case: Fixed<->Byte promotions

https://bit.ly/2yuRjpw

The link above points to what looks like an aborted attempt to show
that fixed's and bytes can be promoted to each other.  According to
the current Avro spec, not such promotions exists.  And since this
test procedure makes no assertions, it doesn't really test this issue
one way or the other.

I suggest that we eliminate the highlighted code.  I'm happy to do
this, but let me know what you think.

Re: Bad test case: Fixed<->Byte promotions

Posted by Doug Cutting <cu...@gmail.com>.
Git blame points to

https://issues.apache.org/jira/projects/AVRO/issues/AVRO-1442

Which claims to be improving errors.  Looks like maybe the tests need to be
improved, not removed?

Doug

On Wed, Oct 24, 2018 at 12:13 AM Raymie Stata <rs...@yahoo.com.invalid>
wrote:

> https://bit.ly/2yuRjpw
>
> The link above points to what looks like an aborted attempt to show
> that fixed's and bytes can be promoted to each other.  According to
> the current Avro spec, not such promotions exists.  And since this
> test procedure makes no assertions, it doesn't really test this issue
> one way or the other.
>
> I suggest that we eliminate the highlighted code.  I'm happy to do
> this, but let me know what you think.
>