You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "wxbty (via GitHub)" <gi...@apache.org> on 2023/06/25 08:30:23 UTC

[GitHub] [apisix] wxbty commented on pull request #9663: fix: bugfix of limit-conn plugin

wxbty commented on PR #9663:
URL: https://github.com/apache/apisix/pull/9663#issuecomment-1605931386

   > Hi @wxbty, test cases are needed
   
   Because the log_by_lua_block stage is after returning to the client, it will be more difficult for us to use assertion verification in the unit test, which may be the reason why this bug has not been found.
   I can only think of verifying through logs.
   before modify:
   ![image](https://github.com/apache/apisix/assets/38374721/414b2915-3e90-4812-8212-f06fa601a230)
   after modify:
   ![image](https://github.com/apache/apisix/assets/38374721/dde51ffa-5b8f-4e67-8791-a9b879b6161f)
   
   do you have a better suggestion?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org