You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/06/25 10:46:45 UTC
[GitHub] [doris] yiguolei opened a new pull request, #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
yiguolei opened a new pull request, #21149:
URL: https://github.com/apache/doris/pull/21149
## Proposed changes
2.0 alpha the workload group does not have property mem_limit, but it is a required propery in 2.0 beta, so the check will failed.
Skip the check and allow upgrade successfully.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606024500
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #21149:
URL: https://github.com/apache/doris/pull/21149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606053264
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606091376
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.78 seconds
stream load tsv: 460 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 57 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select: 68.9 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230625132154_clickbench_pr_167244.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606023564
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606023592
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on code in PR #21149:
URL: https://github.com/apache/doris/pull/21149#discussion_r1241143276
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -281,8 +281,13 @@ public static WorkloadGroup read(DataInput in) throws IOException {
@Override
public void gsonPostProcess() throws IOException {
- String memoryLimitString = properties.get(MEMORY_LIMIT);
- this.memoryLimitPercent = Double.parseDouble(memoryLimitString.substring(0, memoryLimitString.length() - 1));
+ if (properties.containsKey(MEMORY_LIMIT)) {
+ String memoryLimitString = properties.get(MEMORY_LIMIT);
+ this.memoryLimitPercent = Double.parseDouble(memoryLimitString.substring(0,
+ memoryLimitString.length() - 1));
+ } else {
+ this.memoryLimitPercent = 100;
Review Comment:
properties.put(MEMORY_LIMIT, "100");
this.memoryLimitPercent = 100;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606053545
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #21149: [bugfix](workloadgroup) could not upgrade from 2.0 alpha
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #21149:
URL: https://github.com/apache/doris/pull/21149#issuecomment-1606052486
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org