You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Oleksandr Shevchenko (JIRA)" <ji...@apache.org> on 2018/09/10 17:31:00 UTC

[jira] [Comment Edited] (MAPREDUCE-7138) ThrottledContainerAllocator in MRAppBenchmark should implement RMHeartbeatHandler

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609548#comment-16609548 ] 

Oleksandr Shevchenko edited comment on MAPREDUCE-7138 at 9/10/18 5:30 PM:
--------------------------------------------------------------------------

Patch attached.
ThrottledContainerAllocator implements RMHeartbeatHandler interface and getLastHeartbeatTime() returns Time.now() to be able to send JobCommitCompletedEvent in CommitterEventHandler#handleJobCommit (waitForValidCommitWindow method checks the last heartbeat time). 
Please review the patch.
Thanks.


was (Author: oshevchenko):
Patch attached.
ThrottledContainerAllocator implements RMHeartbeatHandler interface and getLastHeartbeatTime() returns Time.now() to be able to send JobCommitCompletedEvent in CommitterEventHandler#handleJobCommit (waitForValidCommitWindow check the last heartbeat time). 
Please review the patch.
Thanks.

> ThrottledContainerAllocator in MRAppBenchmark should implement RMHeartbeatHandler
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7138
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7138
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Minor
>         Attachments: MAPREDUCE-7138.001.patch
>
>
> MRAppBenchmark#benchmark2 test fails with the following exception:
> {noformat}
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.v2.app.MRAppBenchmark$ThrottledMRApp$ThrottledContainerAllocator cannot be cast to org.apache.hadoop.mapreduce.v2.app.rm.RMHeartbeatHandler
> 	at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.getRMHeartbeatHandler(MRAppMaster.java:718)
> 	at org.apache.hadoop.mapreduce.v2.app.MRApp.createCommitterEventHandler(MRApp.java:665)
> 	at org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceInit(MRAppMaster.java:391)
> 	at org.apache.hadoop.mapreduce.v2.app.MRApp.serviceInit(MRApp.java:266)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	at org.apache.hadoop.mapreduce.v2.app.MRApp.submit(MRApp.java:294)
> 	at org.apache.hadoop.mapreduce.v2.app.MRApp.submit(MRApp.java:279)
> 	at org.apache.hadoop.mapreduce.v2.app.MRAppBenchmark.run(MRAppBenchmark.java:69)
> 	at org.apache.hadoop.mapreduce.v2.app.MRAppBenchmark.benchmark2(MRAppBenchmark.java:268)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> {noformat}
> since ThrottledContainerAllocator doesn't implement RMHeartbeatHandler interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org