You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/12/01 19:21:52 UTC

Review Request 28558: Added DiskInfoChecker task validator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28558/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
-------

Added DiskInfo validator to do the checks that were previously inside resources.cpp.


Diffs
-----

  src/common/protobuf_utils.hpp bc3ef2a5f4e80c511d19cff6a4fb822c8d247571 
  src/common/protobuf_utils.cpp baf04a6434e6f19e7e06e98c2d7795f87087eb0b 
  src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e 
  src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d 
  src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2 

Diff: https://reviews.apache.org/r/28558/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 28558: Added DiskInfoChecker task validator.

Posted by Dominic Hamon <dh...@twopensource.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28558/#review63402
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/28558/#comment105653>

    any chance of depending on 20423 to get some love for cleanup?


- Dominic Hamon


On Dec. 1, 2014, 10:21 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28558/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 10:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added DiskInfo validator to do the checks that were previously inside resources.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp bc3ef2a5f4e80c511d19cff6a4fb822c8d247571 
>   src/common/protobuf_utils.cpp baf04a6434e6f19e7e06e98c2d7795f87087eb0b 
>   src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e 
>   src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d 
>   src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2 
> 
> Diff: https://reviews.apache.org/r/28558/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>