[jira] [Commented] (KAFKA-6514) Add API version as a tag for the RequestsPerSec metric

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349012#comment-16349012 ] 

ASF GitHub Bot commented on KAFKA-6514:
---------------------------------------

allenxwang opened a new pull request #4506: KAFKA-6514: Add API version as a tag for the RequestsPerSec metric
URL: https://github.com/apache/kafka/pull/4506
 
 
   Updated `RequestChannel` to include `version` as a tag for all RequestsPerSec metrics. Updated tests to verify that the extra tag exists.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add API version as a tag for the RequestsPerSec metric
> ------------------------------------------------------
>
>                 Key: KAFKA-6514
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6514
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0.0
>            Reporter: Allen Wang
>            Priority: Major
>
> After we upgrade broker to a new version, one important insight is to see how many clients have been upgraded so that we can switch the message format when most of the clients have also been updated to the new version to minimize the performance penalty. 
> RequestsPerSec with the version tag will give us that insight.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)