You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/20 14:17:33 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
mozga-intel opened a new pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683
## Description ##
Exit 0, returns 'true' and then the CI is blocking; the 0 cannot be returned.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947718192
I'm not sure I can follow you.
Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947945454
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel edited a comment on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel edited a comment on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947785088
> I'm not sure I can follow you.
>
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
@marcoabreu ; Thanks for the question!
From man bash on return [n]
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
on exit [n]
> Cause the shell to exit with a status of n. If n is omitted, the exit status is that of the last command executed. A trap on EXIT is executed before the shell terminates.
Finally, functions, when called, the exit 0 (within the function) exits a code ~ without a failure. The return has nothing to do with exit codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel edited a comment on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel edited a comment on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947785088
> I'm not sure I can follow you.
>
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
@marcoabreu
From man bash on return [n]
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
on exit [n]
> Cause the shell to exit with a status of n. If n is omitted, the exit status is that of the last command executed. A trap on EXIT is executed before the shell terminates.
Finally, functions, when called, the exit 0 (within the function) exits a code ~ without a failure. The return has nothing to do with exit codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-948978234
thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-948277448
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#discussion_r732904405
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -740,19 +740,17 @@ sanity_clang() {
GIT_DIFFERENCE=$(git diff)
if [[ -z $GIT_DIFFERENCE ]]; then
git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
Review comment:
Done! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947712564
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, windows-cpu, centos-cpu, clang, centos-gpu, unix-gpu, unix-cpu, sanity, miscellaneous, website, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-948277468
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-948382096
@szha Could you please help with a merge? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu edited a comment on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
marcoabreu edited a comment on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947718192
I'm not sure I can follow you.
Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947945412
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#issuecomment-947785088
> I'm not sure I can follow you.
>
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
@marcoabreu
From man bash on return [n]
> Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?
on exit [n]
> Cause the shell to exit with a status of n. If n is omitted, the exit status is that of the last command executed. A trap on EXIT is executed before the shell terminates.
Finally, functions, when called, the exit 0 (within the function) exits a code. The return has nothing to do with exit codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#discussion_r732903962
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -740,19 +740,17 @@ sanity_clang() {
GIT_DIFFERENCE=$(git diff)
if [[ -z $GIT_DIFFERENCE ]]; then
git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
- exit 0
+ else
+ echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+ echo "| Clang-format failures found! Run: "
+ echo "| tools/lint/clang_format_ci.sh ${BASE_SHA} "
+ echo "| to fix this error. "
+ echo "| For more info, see: https://mxnet.apache.org/versions/master/community/clang_format_guide"
+ echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+
+ echo "$GIT_DIFFERENCE"
+ git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
Review comment:
At the end of a function, exit 0 is fine, I want to stop executing a script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#discussion_r732886072
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -740,19 +740,17 @@ sanity_clang() {
GIT_DIFFERENCE=$(git diff)
if [[ -z $GIT_DIFFERENCE ]]; then
git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
Review comment:
You can use
return 0
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -740,19 +740,17 @@ sanity_clang() {
GIT_DIFFERENCE=$(git diff)
if [[ -z $GIT_DIFFERENCE ]]; then
git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
- exit 0
+ else
+ echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+ echo "| Clang-format failures found! Run: "
+ echo "| tools/lint/clang_format_ci.sh ${BASE_SHA} "
+ echo "| to fix this error. "
+ echo "| For more info, see: https://mxnet.apache.org/versions/master/community/clang_format_guide"
+ echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+
+ echo "$GIT_DIFFERENCE"
+ git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
Review comment:
end
return 1
at the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org