You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "ChrisZMF (via GitHub)" <gi...@apache.org> on 2023/08/09 11:00:12 UTC

[GitHub] [kvrocks] ChrisZMF commented on a diff in pull request #1652: Fix add/delete repeated members error in zset/set/hash types

ChrisZMF commented on code in PR #1652:
URL: https://github.com/apache/kvrocks/pull/1652#discussion_r1288312109


##########
src/types/redis_set.cc:
##########
@@ -70,7 +70,11 @@ rocksdb::Status Set::Add(const Slice &user_key, const std::vector<Slice> &member
   WriteBatchLogData log_data(kRedisSet);
   batch->PutLogData(log_data.Encode());
   std::string sub_key;
+  std::unordered_set<std::string> mset;

Review Comment:
   `rocksdb::Slice` is not ok, it can't pass the compiling.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org