You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/16 09:31:43 UTC
[GitHub] [arrow] kiszk opened a new pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
kiszk opened a new pull request #8674:
URL: https://github.com/apache/arrow/pull/8674
This PR is a follow-up of #8494 . The fast_float vendor library does not support big-endian of exponential float notion in `from_chars`. This PR correctly copies the available 32-bit (offset 4-7 on big-endian) to the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk closed pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
kiszk closed pull request #8674:
URL: https://github.com/apache/arrow/pull/8674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728582428
@wesm Thanks to @kiszk, I figured that out.
That we could run CI on IBM mainframe-like systems was a shock to me. :-) I knew about POWER, but not that. So I learned something new today.
As written above, I have a patch that work. I'll issue a new release soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-729344240
@pitrou Will you open another PR to integrate ver. 0.2.0 of fast_float?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728252123
The issue has been fixed upstream (big endian support). I am running exhaustive tests and once they complete, I will issue a new release.
If you wish, you can wait for this new release instead of merging a vendored change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-727869105
https://issues.apache.org/jira/browse/ARROW-10610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-729580682
@pitrou Sounds good, I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728528823
Travis CI has s390x architecture (that's how we've been testing on BE)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728178811
@kiszk Thanks for the report.
@pitrou How do you test Big Endian support? I have different ARM boards, but none of them run in Big Endian mode. I have not been able to find any publicly accessible CI system that run tests on Big Endian systems. I have a POWER system, but it is only little endian.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-727958817
Not yet. I will report this issue today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728997394
Version 0.2.0 of fast_float is out:
https://github.com/lemire/fast_float/releases/tag/v0.2.0
Release notes:
- Support for Big Endian systems
- Build with pedantic flags under GNU GCC without warnings
- More standard compliant handling of problematic strings (issue19)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728217716
We are looking into fixing this upstream (big endian support).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728217863
(The hard part is to add the necessary CI testing.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-729570863
@kiszk I will, unless you beat me to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728155154
Reported at https://github.com/lemire/fast_float/issues/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-728226679
(I managed to add CI tests now.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8674: ARROW-10610: [C++] Support exponential float nontion on big-endian in fast_float
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-727895100
Did you report the issue upstream?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org