You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2017/01/05 10:27:17 UTC

Review Request 55204: ATLAS-1427 : Support an option to exclude protocols in SSL mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55204/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1427
    https://issues.apache.org/jira/browse/ATLAS-1427


Repository: atlas


Description
-------

This patch includes changes to exclude protocols in SSL mode.
The protocols to exclude can be specified in atlas-application property atlas.ssl.exclude.protocols=TLSv1,TLSv1.1


Diffs
-----

  common/src/main/java/org/apache/atlas/security/SecurityProperties.java 191d869 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java a6af5a2 

Diff: https://reviews.apache.org/r/55204/diff/


Testing
-------

Run mvn clean install to run testcase,they are passing.
Did manual testing to verify the connection protocol served from atlas server for http request when tls is enbaled on firefox and IE browser. [testing summary report | https://reviews.apache.org/media/uploaded/files/2017/01/05/2bc1abfe-207e-4486-b382-17ff35b72253__ATLAS-1427-Exclude-TLS-version-Testing-summary-report.xlsx]


File Attachments
----------------

Testing summary report
  https://reviews.apache.org/media/uploaded/files/2017/01/05/2bc1abfe-207e-4486-b382-17ff35b72253__ATLAS-1427-Exclude-TLS-version-Testing-summary-report.xlsx


Thanks,

Nixon Rodrigues


Re: Review Request 55204: ATLAS-1427 : Support an option to exclude protocols in SSL mode

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55204/#review160604
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 5, 2017, 10:27 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55204/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 10:27 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1427
>     https://issues.apache.org/jira/browse/ATLAS-1427
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes changes to exclude protocols in SSL mode.
> The protocols to exclude can be specified in atlas-application property atlas.ssl.exclude.protocols=TLSv1,TLSv1.1
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/security/SecurityProperties.java 191d869 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java a6af5a2 
> 
> Diff: https://reviews.apache.org/r/55204/diff/
> 
> 
> Testing
> -------
> 
> Run mvn clean install to run testcase,they are passing.
> Did manual testing to verify the connection protocol served from atlas server for http request when tls is enbaled on firefox and IE browser. [testing summary report | https://reviews.apache.org/media/uploaded/files/2017/01/05/2bc1abfe-207e-4486-b382-17ff35b72253__ATLAS-1427-Exclude-TLS-version-Testing-summary-report.xlsx]
> 
> 
> File Attachments
> ----------------
> 
> Testing summary report
>   https://reviews.apache.org/media/uploaded/files/2017/01/05/2bc1abfe-207e-4486-b382-17ff35b72253__ATLAS-1427-Exclude-TLS-version-Testing-summary-report.xlsx
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>