[GitHub] spark pull request: [SPARK-2193] Improve tasks preferrd locality b...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/1131#issuecomment-54372737
  
    Hi @li-zhihui,
    
    Sorry for allowing this to sit unreviewed for so long.
    
    To check my understanding, the original issue was that an individual executor's pending task queue might have non-preferred tasks that appear ahead of preferred ones in the queue?  It looks like this might have been partially addressed by #1313, which modified TaskSetManage to maintain a separate list of pending tasks without locality preferences: https://github.com/apache/spark/commit/63bdb1f41b4895e3a9444f7938094438a94d3007#diff-bad3987c83bd22d46416d3dd9d208e76R193.
    
    Since we now maintain separate lists to track pending tasks for executors, hosts, and racks, I don't think that we need this sorting.  If you agree, do you mind closing this pull request?  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org