You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/02/03 03:48:13 UTC
[GitHub] [hudi] boneanxs opened a new pull request, #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
boneanxs opened a new pull request, #7837:
URL: https://github.com/apache/hudi/pull/7837
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
If we use `withInferFunction` to set the default value of `SPILLABLE_MAP_BASE_PATH`, this default value will be set to `HoodieWriteConfig`'s `properties`, and will be serialized to all executors. This could introduce the issue that if the driver doesn't have the same temporary location with the executors side(e.g. driver: /mnt/disk1, executor: /mnt/disk2), the executor would throw error to create the spilled map path(since the executor machine doesn't have the directory /mnt/disk1).
```java
Caused by: org.apache.hudi.exception.HoodieIOException: Unable to create :/mnt/ssd/0/yarn/nm-local-dir/usercache/test/appcache/application_1673593627114_3970647/hudi-BITCASK-e3741235-6571-4112-8b20-271408148238
at org.apache.hudi.common.util.collection.ExternalSpillableMap.getDiskBasedMap(ExternalSpillableMap.java:119)
at org.apache.hudi.common.util.collection.ExternalSpillableMap.getDiskBasedMapNumEntries(ExternalSpillableMap.java:138)
at org.apache.hudi.io.HoodieMergeHandle.init(HoodieMergeHandle.java:268)
at org.apache.hudi.io.HoodieMergeHandle.(HoodieMergeHandle.java:129)
at org.apache.hudi.io.HoodieMergeHandle.(HoodieMergeHandle.java:121)
at org.apache.hudi.io.HoodieConcatHandle.(HoodieConcatHandle.java:81)
at org.apache.hudi.io.HoodieMergeHandleFactory.create(HoodieMergeHandleFactory.java:60)
at org.apache.hudi.table.action.commit.BaseSparkCommitActionExecutor.getUpdateHandle(BaseSparkCommitActionExecutor.java:386)
at org.apache.hudi.table.action.commit.BaseSparkCommitActionExecutor.handleUpdate(BaseSparkCommitActionExecutor.java:363)
at org.apache.hudi.table.action.commit.BaseSparkCommitActionExecutor.handleUpsertPartition(BaseSparkCommitActionExecutor.java:330)
... 29 more
Caused by: java.io.IOException: Unable to create :/mnt/ssd/0/yarn/nm-local-dir/usercache/test/appcache/application_1673593627114_3970647/hudi-BITCASK-e3741235-6571-4112-8b20-271408148238
at org.apache.hudi.common.util.FileIOUtils.mkdir(FileIOUtils.java:70)
at org.apache.hudi.common.util.collection.DiskMap.(DiskMap.java:55)
at org.apache.hudi.common.util.collection.BitCaskDiskMap.(BitCaskDiskMap.java:98)
at org.apache.hudi.common.util.collection.ExternalSpillableMap.getDiskBasedMap(ExternalSpillableMap.java:116)
... 38 more
```
A better solution is to calculate the temporary location when calling `getSpillableMapBasePath`
### Impact
_Describe any public API or user-facing feature change or any performance impact._
no
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1414983479
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888",
"triggerID" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c514180b843d6bcc4fc939803398da8bf00137d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1415721333
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888",
"triggerID" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"triggerType" : "PUSH"
}, {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14894",
"triggerID" : "1415304755",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5c514180b843d6bcc4fc939803398da8bf00137d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1415319029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888",
"triggerID" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"triggerType" : "PUSH"
}, {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14894",
"triggerID" : "1415304755",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5c514180b843d6bcc4fc939803398da8bf00137d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1414969028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c514180b843d6bcc4fc939803398da8bf00137d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] boneanxs commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1415304755
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7837:
URL: https://github.com/apache/hudi/pull/7837#issuecomment-1415284337
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888",
"triggerID" : "5c514180b843d6bcc4fc939803398da8bf00137d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c514180b843d6bcc4fc939803398da8bf00137d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14888)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars merged pull request #7837: [HUDI-5692] SpillableMapBasePath should be lazily loaded
Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars merged PR #7837:
URL: https://github.com/apache/hudi/pull/7837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org