You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Revolyssup (via GitHub)" <gi...@apache.org> on 2023/11/21 18:37:25 UTC
[PR] fix: add labels field in stream_route schema [apisix]
Revolyssup opened a new pull request, #10529:
URL: https://github.com/apache/apisix/pull/10529
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes multiple issues in ingress controller where the `labels` field is expected. This makes this resource consistent with other resource schemas.
Related issues:
https://github.com/apache/apisix-ingress-controller/issues/2057
https://github.com/apache/apisix-ingress-controller/issues/2023
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #10529:
URL: https://github.com/apache/apisix/pull/10529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401736201
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
This field is present in other resources as well. Like route and consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401742097
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
Is it necessary, can we fix this on the ingress side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401802642
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
stream_route doesn't have metadata field also. If it has that,labels could be pushed there. Ingress needs some field to add the labels, so the schema will need change here.
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
stream_route doesn't have metadata field also. If it had that,labels could be pushed there. Ingress needs some field to add the labels, so the schema will need change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401888399
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401731671
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
Could you add comment for the field so that we can know why we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add labels field in stream_route schema [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10529:
URL: https://github.com/apache/apisix/pull/10529#discussion_r1401882498
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
Please add comment here, like
```
The ingress project need this field
```
##########
apisix/schema_def.lua:
##########
@@ -892,6 +892,7 @@ _M.stream_route = {
create_time = timestamp_def,
update_time = timestamp_def,
remote_addr = remote_addr_def,
+ labels = labels_def,
Review Comment:
Please add a comment here, like
```
The ingress project need this field
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org