[jira] [Commented] (CB-6895) Generated manifest skips some properties

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027195#comment-14027195 ] 

ASF GitHub Bot commented on CB-6895:
------------------------------------

GitHub user rodms10 opened a pull request:

    https://github.com/apache/cordova-lib/pull/26

    CB-6895 Add more config properties into manifest

    Added `fullscreen`, `orientation` and `launch_path` to the manifest. Plus clean up and indentation. @zalun, can you take a look?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rodms10/cordova-lib CB-6895

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 6cd02291983dd180412b93c62f7ca7476d8436d0
Author: Rodrigo Silveira <ro...@outlook.com>
Date:   2014-06-10T22:29:49Z

    CB-6895 Add more config properties into manifest

----


> Generated manifest skips some properties
> ----------------------------------------
>
>                 Key: CB-6895
>                 URL: https://issues.apache.org/jira/browse/CB-6895
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: FirefoxOS
>    Affects Versions: 3.5.0
>            Reporter: Rodrigo Silveira
>            Assignee: Rodrigo Silveira
>
> The properties *launch_path* and *installs_allowed_from* are hard coded and should instead come from *content* and *access* elements in *config.xml*.
> Manifest doesn't support fullscreen and portrait.
> See [config.xml docs|http://cordova.apache.org/docs/en/3.5.0/config_ref_index.md.html#The%20config.xml%20File] for cordova props we can use and [app manifest doc|https://developer.mozilla.org/en-US/Apps/Build/Manifest] for what firefoxos supports.



--
This message was sent by Atlassian JIRA
(v6.2#6252)