You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2014/03/28 05:43:17 UTC

[jira] [Commented] (YARN-1887) FairSchedulerAppsBlock and AppsBlock duplicate much code

    [ https://issues.apache.org/jira/browse/YARN-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950364#comment-13950364 ] 

Tsuyoshi OZAWA commented on YARN-1887:
--------------------------------------

Overview of changes:
1. AppBlock has 3 methods: rencer(), getTBocy(), and getAppsTableData(). render() callbacks getTBody() and getAppsTableData().
2. FairSchedulerAppsBlock overrides getTBody() and getAppsTableData().

> FairSchedulerAppsBlock and AppsBlock duplicate much code
> --------------------------------------------------------
>
>                 Key: YARN-1887
>                 URL: https://issues.apache.org/jira/browse/YARN-1887
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1887.1.patch
>
>
> Either now or after YARN-1809, FairSchedulerAppsBlock and AppsBlock duplicate much code. Ideally, FairSchedulerAppsBlock should extends AppsBlock to reuse most code, and override the method of creating app table headers and rows



--
This message was sent by Atlassian JIRA
(v6.2#6252)