You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/18 18:02:31 UTC

[GitHub] [superset] john-bodley commented on a diff in pull request #21815: chore: Remove CROSS_REFERENCES feature flag

john-bodley commented on code in PR #21815:
URL: https://github.com/apache/superset/pull/21815#discussion_r998555506


##########
superset/config.py:
##########
@@ -466,7 +466,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
     "EMBEDDABLE_CHARTS": True,
     "DRILL_TO_DETAIL": False,
     "DATAPANEL_CLOSED_BY_DEFAULT": False,
-    "CROSS_REFERENCES": False,

Review Comment:
   Is the preferred strategy to first enable the `CROSS_REFERENCES` feature by default and then deprecate the feature in version 3.0? 
   
   Also [SIP-57](https://github.com/apache/superset/issues/12566) changing the default or removing a feature flag is deemed a breaking change and thus the appropriate actions need to be undertaken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org