You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/01 11:27:54 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10598: ARROW-13054: [C++] Add option to specify the first day of the week for the "day_of_week" temporal kernel

pitrou commented on a change in pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#discussion_r662204202



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -624,15 +636,20 @@ ARROW_EXPORT
 Result<Datum> Day(const Datum& values, ExecContext* ctx = NULLPTR);
 
 /// \brief DayOfWeek returns number of the day of the week value for each element of
-/// `values`. Week starts on Monday denoted by 0 and ends on Sunday denoted by 6.
+/// `values`. By default week starts on Monday denoted by 0 and ends on Sunday denoted

Review comment:
       Nit, but the `\brief` line should be a one-line summary. Leave an empty line before the more detailed description.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org